Skip to content

refactor: Membership.findByUserIdAndTeamId to instance method #26628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
volnei merged 5 commits into from
Jan 10, 2026
Merged

refactor: Membership.findByUserIdAndTeamId to instance method #26628

volnei merged 5 commits into from
Jan 10, 2026
+117 −90

Conversation

@joeauyeung
Copy link
Contributor

@joeauyeung joeauyeung commented Jan 9, 2026

What does this PR do?

Refactors the MembershipRepository.findByUserIdAndTeamId to an instance method.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

@joeauyeung joeauyeung requested a review from a team as a code owner January 9, 2026 17:13
@graphite-app graphite-app bot added the enterprise area: enterprise, audit log, organisation, SAML, SSO label Jan 9, 2026
@graphite-app graphite-app bot requested a review from a team January 9, 2026 17:13
@graphite-app graphite-app bot added the core area: core, team members only label Jan 9, 2026
cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Jan 9, 2026
View reviewed changes
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 13 files

@devin-ai-integration @joeauyeung
fix: update MembershipRepository mocks to use vi.hoisted() for proper…
aaa1254 
… hoisting

Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>
@vercel
Copy link

vercel bot commented Jan 9, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

4 Skipped Deployments
Project Deployment Review Updated (UTC)
api-v2 Ignored Ignored Preview Jan 12, 2026 5:11pm
cal Ignored Ignored Jan 12, 2026 5:11pm
cal-companion Ignored Ignored Preview Jan 12, 2026 5:11pm
cal-eu Ignored Ignored Jan 12, 2026 5:11pm

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

E2E results are ready!

volnei
volnei approved these changes Jan 10, 2026
View reviewed changes
Copy link
Contributor

@volnei volnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@volnei volnei merged commit f6d3b11 into main Jan 10, 2026
77 of 80 checks passed
@volnei volnei deleted the refactor-find-by-userid-and-teamid-to-instance branch January 10, 2026 01:37
Anshumancanrock pushed a commit to Anshumancanrock/cal.com that referenced this pull request Jan 12, 2026
@joeauyeung @devin-ai-integration @Anshumancanrock
refactor: Membership.findByUserIdAndTeamId to instance method (calc…
8e89986 
…om#26628)

* Make  and instance method

* Refactor files

* fix: update MembershipRepository mocks to use vi.hoisted() for proper hoisting

Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

@volnei volnei volnei approved these changes

Assignees

No one assigned

Labels

core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO ready-for-e2e size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joeauyeung @volnei