chore: disable apps with missing required keys #27012
Merged
+215
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new companion-typecheck.yml workflow that runs TypeScript type checking for the companion app. This would have caught the missing useEffect import issue in PR #26931. Changes: - Add new companion-typecheck.yml workflow file - Update pr.yml to call the new workflow when companion files change - Add typecheck-companion to the required jobs list Co-Authored-By: anik@cal.com <adhabal2002@gmail.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
auto-merge was automatically disabled
January 19, 2026 17:19
Pull request was converted to draft
Contributor
|
Further conversations concluded as follows; for some reason invalid apps are set as enabled, instead of doing this we should fix the app registration script to not toggle enabled to true unless the app is setup correctly. |
anikdhabal
force-pushed
the
hide-apps-from-appstore
branch
from
e8543aa to
9c2e58e
Compare
emrysal
reviewed
Jan 19, 2026
anikdhabal
changed the title
devin-ai-integration bot
added a commit
that referenced
this pull request
Jan 21, 2026
PR #27012 introduced logic to disable apps without valid keys during seeding. This caused the alby payment app tests to fail because the alby app was disabled in the App table when its environment keys weren't configured. This fix adds an ensureAppEnabled helper function that enables the app in the App table before running the tests, treating it as a mock/test setup step. Co-Authored-By: alex@cal.com <me@alexvanandel.com>
9 tasks
emrysal
added a commit
that referenced
this pull request
Jan 21, 2026
…27071) PR #27012 introduced logic to disable apps without valid keys during seeding. This caused the alby payment app tests to fail because the alby app was disabled in the App table when its environment keys weren't configured. This fix adds an ensureAppEnabled helper function that enables the app in the App table before running the tests, treating it as a mock/test setup step. Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Disabled unconfigured apps by validating required keys and toggling enablement during sync and seeding.
Written for commit 740c987. Summary will update on new commits.