-
Notifications
You must be signed in to change notification settings - Fork 11.6k
chore: Add calendar subscription error better management (backoff) #27019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 12 files
E2E results are ready! |
| const retryableWindowFilter: Prisma.SelectedCalendarWhereInput = { | ||
| OR: [{ syncSubscribedErrorAt: null }, { syncSubscribedErrorAt: { lt: oneDayAgo } }], | ||
| }; | ||
|
|
||
| const retryableErrorCountFilter: Prisma.SelectedCalendarWhereInput = { | ||
| syncSubscribedErrorCount: { lt: MAX_SUBSCRIBE_ERRORS }, | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like it will not be an issue, but just to double check we don't need partial indexes for this new filters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah.. this is just a 100 rows query filtered by users (already indexed) so there's no issue 🙏🏼
What does this PR do?
Summary by cubic
Adds error tracking and backoff for calendar subscriptions to reduce repeated failures and unnecessary retries. Subscriptions now pause for 24 hours after an error and stop after 3 failures.
New Features
Migration
Written for commit b345ad6. Summary will update on new commits.