fix: correct bookingUrl for EU instance in API responses #27046
Merged
+28
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For EU deployments where WEBAPP_URL (app.cal.eu) differs from WEBSITE_URL (cal.com), use WEBAPP_URL for non-org booking URLs. This fixes incorrect bookingUrl in API responses for EU instance.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
supalarry
requested changes
Jan 20, 2026
Contributor
supalarry
left a comment
supalarry
left a comment
There was a problem hiding this comment.
Request to re-use code:
| return options.protocol ? WEBSITE_URL : WEBSITE_URL.replace("https://", "").replace("http://", ""); | ||
| if (!slug) { | ||
| // Use WEBAPP_URL if domains differ (e.g., EU: app.cal.eu vs cal.com) | ||
| const getBaseDomain = (hostname: string) => hostname.split(".").slice(-2).join("."); |
Contributor
There was a problem hiding this comment.
The logic for const getBaseDomain is copied from getTldPlus1 function (search for it in vs code).
We already have 2 copies of getTldPlus1 - can we define it only once and re-use it in the 2 existing places and here and get rid of copies?
Member
Author
There was a problem hiding this comment.
Thank you for the review, made following changes:
- created packages/lib/getTldPlus1.ts - new shared utility
- updated getSafeRedirectUrl.ts - removed inline copy, now imports shared function
- updated orgDomains.ts - uses shared getTldPlus1 instead of inline getBaseDomain
auto-merge was automatically disabled
January 20, 2026 11:32
Pull request was converted to draft
… function instead of inline copy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes incorrect
bookingUrlfield returned byapi.cal.eu/v2/event-typesfor non-organization users.Problem
https://cal.com/user/eventinstead ofhttps://app.cal.eu/user/eventcal.euredirects to marketing page, not booking pagesapp.cal.euSolution
Updated getOrgFullOrigin() to detect when
WEBSITE_URLandWEBAPP_URLare on different root domains. When they differ (EU case), useWEBAPP_URLinstead.app.cal.comcal.com/user/event✅app.cal.euapp.cal.eu/user/event✅Changes
Type of change
How should this be tested?
yarn test packages/features/ee/organizations/lib/orgDomains.test.ts- all 10 tests passGET api.cal.eu/v2/event-typesreturns correctbookingUrl