feat: show invoices on team/org #27120
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 9 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/web/modules/settings/billing/components/InvoicesTable.tsx">
<violation number="1" location="apps/web/modules/settings/billing/components/InvoicesTable.tsx:41">
P2: Localize the filter column title instead of hardcoding "Date" to keep UI text translatable.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
|
||
| const createdAtColumn: Extract<FilterableColumn, { type: Extract<FilterType, "dr"> }> = { | ||
| id: "createdAt", | ||
| title: "Date", |
There was a problem hiding this comment.
P2: Localize the filter column title instead of hardcoding "Date" to keep UI text translatable.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/web/modules/settings/billing/components/InvoicesTable.tsx, line 41:
<comment>Localize the filter column title instead of hardcoding "Date" to keep UI text translatable.</comment>
<file context>
@@ -0,0 +1,236 @@
+
+const createdAtColumn: Extract<FilterableColumn, { type: Extract<FilterType, "dr"> }> = {
+ id: "createdAt",
+ title: "Date",
+ type: ColumnFilterType.DATE_RANGE,
+};
</file context>
Devin AI is addressing Cubic AI's review feedbackA Devin session has been created to address the issues identified by Cubic AI. |
|
Reviewed the Cubic AI feedback for this PR. The reported issue regarding localizing the "Date" filter column title has a confidence score of 8/10, which is below the 9/10 threshold for automated fixes. Issue skipped: Localize the filter column title instead of hardcoding "Date" (confidence: 8/10) No changes were made as part of this review since the confidence threshold was not met. If this issue should still be addressed, please let me know and I can implement the fix. |
Devin AI is resolving merge conflictsThis PR has merge conflicts with the Devin will:
If you prefer to resolve conflicts manually, you can close the Devin session and handle it yourself. |
Resolved merge conflicts in: - packages/features/ee/billing/service/billingProvider/IBillingProviderService.ts - packages/features/ee/billing/service/billingProvider/StripeBillingService.ts Both conflicts were simple cases where both branches made the same change (adding 'type' keyword to imports). Kept the consistent import style. Co-Authored-By: unknown <>
eunjae-lee
left a comment
eunjae-lee
left a comment
There was a problem hiding this comment.
Working well! can you clean up common.json ? then i'll approve this.
| "last_7_days": "Last 7 days", | ||
| "last_30_days": "Last 30 days", | ||
| "last_3_months": "Last 3 months", | ||
| "last_6_months": "Last 6 months", | ||
| "last_12_months": "Last 12 months", | ||
| "custom_range": "Custom range", |
There was a problem hiding this comment.
i think they're not used in this PR
| ) : ( | ||
| <> | ||
| <div className="overflow-x-auto"> | ||
| <Table> |
There was a problem hiding this comment.
not blocking but, any reason why use use <Table> (not <DataTable> or <DataTableWrapper>) while you're using it along with DataTableProvider?
(fyi, if you want, Devin could probably do it well with packages/features/data-table/GUIDE.md)
E2E results are ready! |
What does this PR do?
How should this be tested?
Enable stripe - create a team/org - pay invoice - goto stripe dashboard - advance invoice by X months ensure all invoices are loaded
Checklist
Summary by cubic
Adds an invoice list to Team and Org Billing pages with date range filtering, cursor pagination, status badges, and links to hosted invoices/PDF downloads. Implements a new TRPC endpoint and Stripe service method to fetch invoices per subscription.
New Features
API
Written for commit 5f319e7. Summary will update on new commits.