Skip to content

Conversation

@ThyMinimalDev
Copy link
Contributor

@ThyMinimalDev ThyMinimalDev commented Jan 22, 2026

What does this PR do?

Adds rrHostSubsetIds support to the reschedule booking endpoint (POST /v2/bookings/:bookingUid/reschedule), matching the existing implementation in the create booking endpoint.

This allows API consumers to specify a subset of round-robin hosts when rescheduling a booking, enabling them to control which hosts are considered for the rescheduled booking.

Changes

  1. Added rrHostSubsetIds optional property to RescheduleBookingInput_2024_08_13 with proper validation decorators (@IsArray, @IsInt)
  2. Updated transformInputRescheduleBooking to pass through rrHostSubsetIds to the booking handler
  3. Added e2e test that validates rescheduling with rrHostSubsetIds to force a different host

The implementation mirrors the existing pattern in CreateBookingInput_2024_08_13.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A - property is hidden from API docs via @ApiHideProperty().
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  1. Create a round-robin team event type with multiple hosts
  2. Create a booking for that event type with rrHostSubsetIds containing one host
  3. Reschedule the booking via API with rrHostSubsetIds containing a different host
  4. Verify the rescheduled booking is assigned to the new specified host

The e2e test should reschedule a team RR booking and use rrHostSubsetIds to force teamUser2 as host in team-bookings.e2e-spec.ts validates this flow.

Checklist

  • My code follows the style guidelines of this project
  • I have checked if my changes generate no new warnings

Human Review Checklist

  • Verify that the downstream booking handler (handleNewBooking) properly uses rrHostSubsetIds during reschedule operations
  • Confirm validation decorators match the create booking endpoint pattern
  • Review e2e test coverage for edge cases

Link to Devin run: https://app.devin.ai/sessions/597820cc9cef4eb688548701f95063a5
Requested by: @ThyMinimalDev

Co-Authored-By: morgan@cal.com <morgan@cal.com>
@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Co-Authored-By: morgan@cal.com <morgan@cal.com>
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 22, 2026
@ThyMinimalDev ThyMinimalDev marked this pull request as ready for review January 22, 2026 13:16
@ThyMinimalDev ThyMinimalDev requested review from a team as code owners January 22, 2026 13:16
@graphite-app graphite-app bot added foundation core area: core, team members only labels Jan 22, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@ThyMinimalDev ThyMinimalDev merged commit 51976b1 into main Jan 22, 2026
54 checks passed
@ThyMinimalDev ThyMinimalDev deleted the devin/1769085935-add-rrhostsubsetids-to-reschedule branch January 22, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants