fix: await unawaited calendar.events.patch call in updateEvent #27313
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an unhandled promise rejection in the Google Calendar service that could crash the API when hitting Google Calendar quota limits.
In the
updateEventmethod, thecalendar.events.patchcall (used to update the event description with the hangout link) was not awaited. This meant if the patch request failed (e.g., due to quota exceeded errors), the promise rejection would occur after the function returned, bypassing the try/catch block and causing an unhandled rejection.Error that was occurring:
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
calendar.events.patchcall are now properly caught by the surrounding try/catch blockHuman Review Checklist
Link to Devin run: https://app.devin.ai/sessions/3bae43ad0f0a4680899fe9b4e0908aec
Requested by: @ThyMinimalDev