Skip to content

Conversation

@pedroccastro
Copy link
Contributor

What does this PR do?

Standardizes the instant booking location endpoint to use bookingUid instead of numeric bookingId, aligning with other booking endpoints in the codebase.

Changes

Layer File(s) Change
Zod Schema getInstantBookingLocation.schema.ts Change input from bookingId: number to bookingUid: string
Handler getInstantBookingLocation.handler.ts Query by uid instead of id
Frontend useBookings.ts Update query param and tRPC call to use bookingUid

Technical Details

The createInstantBooking response already includes both bookingId and bookingUid. This change uses the uid consistently throughout the instant booking flow.

How should this be tested?

  1. Create an instant booking
  2. Verify the location is retrieved correctly after booking is accepted
  3. Verify URL uses bookingUid parameter

Mandatory Tasks

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.
  • Manually tested locally. No automated test coverage exists for this endpoint currently. Tests will be added in a follow-up PR.

  Use booking uid instead of numeric id for instant booking location
  endpoint, aligning with existing booking endpoint patterns
@pedroccastro pedroccastro marked this pull request as ready for review February 2, 2026 14:57
@graphite-app graphite-app bot added foundation core area: core, team members only labels Feb 2, 2026
@graphite-app graphite-app bot requested a review from a team February 2, 2026 14:57
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Copy link
Contributor

@volnei volnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add some tests on follow up PRs 🙏

@volnei volnei merged commit 1ff307b into main Feb 2, 2026
52 checks passed
@volnei volnei deleted the fix/instant-booking-lookup branch February 2, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants