-
Notifications
You must be signed in to change notification settings - Fork 11.8k
fix: filter attendees in emails when seatsShowAttendees is disabled #27520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 4 files
emrysal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Fixes the issue.
emrysal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting logic inversion
Pull request was converted to draft
E2E results are ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 4 files
Summary by cubic
Fix attendee emails for seated events to only show the recipient when seatsShowAttendees is off. Supports an explicit override and keeps non-seated events unchanged.
Written for commit 7db5bbc. Summary will update on new commits.