Merged
Conversation
joeauyeung
approved these changes
Feb 4, 2026
eunjae-lee
approved these changes
Feb 4, 2026
Paragon: tests updated1 new test generated for this PR. New Tests
DetailsNew Tests
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
pedroccastro
reviewed
Feb 4, 2026
| throw new TRPCError({ code: "UNAUTHORIZED" }); | ||
| } | ||
|
|
||
| await checkRateLimitAndThrowError({ |
Contributor
There was a problem hiding this comment.
Hey! Thanks for looking into this 🙌
I was thinking on a slightly different approach:
- Moving the rate limit check before the billing gate so we can reject early without running the credits/plan queries
- Using sms + smsMonth rate limit types instead of core (short-term + monthly cap)
What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Added per-user rate limiting to the sendVerificationCode handler to smooth bursts and improve responsiveness. This reduces load and keeps the verification flow stable under heavy usage.
Written for commit 1f4d301. Summary will update on new commits.