Draft
Conversation
|
Paragon Review Unavailable Hi @Ryukemeister! You are not toggled active by your team. Reach out to your admin. |
Paragon: tests updated2 updated tests generated for this PR. Updated Tests
DetailsUpdated Tests
|
Contributor
There was a problem hiding this comment.
2 issues found across 28 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/features/bookings/repositories/BookingRepository.ts">
<violation number="1" location="packages/features/bookings/repositories/BookingRepository.ts:1615">
P2: Prisma `include` returns all columns for `eventType`, which violates the guideline to select only needed fields. Use `select` with explicit fields for `eventType` instead of `include` to avoid unnecessary data exposure and overhead.</violation>
</file>
<file name="packages/features/bookings/lib/payment/getBooking.ts">
<violation number="1" location="packages/features/bookings/lib/payment/getBooking.ts:120">
P2: Select only the profile fields that are actually used here. `organizationId` and `username` are fetched but never referenced in this function; drop them to avoid unnecessary data exposure and overhead.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| attendees: true, | ||
| eventType: true, | ||
| eventType: { | ||
| include: { |
Contributor
There was a problem hiding this comment.
P2: Prisma include returns all columns for eventType, which violates the guideline to select only needed fields. Use select with explicit fields for eventType instead of include to avoid unnecessary data exposure and overhead.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/features/bookings/repositories/BookingRepository.ts, line 1615:
<comment>Prisma `include` returns all columns for `eventType`, which violates the guideline to select only needed fields. Use `select` with explicit fields for `eventType` instead of `include` to avoid unnecessary data exposure and overhead.</comment>
<file context>
@@ -1595,7 +1611,18 @@ async updateMany({ where, data }: { where: BookingWhereInput; data: BookingUpdat
attendees: true,
- eventType: true,
+ eventType: {
+ include: {
+ team: {
+ select: {
</file context>
Contributor
Devin AI is addressing Cubic AI's review feedbackA Devin session has been created to address the issues identified by Cubic AI. |
…elect Addresses Cubic AI review feedback (confidence 9/10) to select only the profile fields that are actually used. The organizationId and username fields were fetched but never referenced in this function. Co-Authored-By: unknown <>
Contributor
E2E results are ready! |
Co-Authored-By: rajiv@cal.com <sahalrajiv6900@gmail.com>
Contributor
Author
|
@paragon-evolve |
Paragon: tests updated1 updated test generated for this PR. Updated Tests
DetailsUpdated Tests
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What does this PR do?
Ensures Cal branding is correctly hidden for orgs and team bookings. Branding preference is computed per event and applied across emails, workflows, and verification flows for consistent behavior.
Bug Fixes
Updates since last revision
organizationIdandusernamefields from profiles select ingetBooking.ts(confidence 9/10)Visual Demo (For contributors especially)
N/A - Logic changes only, no UI modifications.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
hideBranding: trueHuman Review Checklist
shouldHideBrandingForEventUsingProfileutility correctly handles all cases (team events, user events, org overrides)Link to Devin run: https://app.devin.ai/sessions/247bb7d6deff45bba56915ce8cc9f42d
Requested by: unknown ()