Skip to content

fix: update routing form identifier hint text with learn more link#27837

Merged
hbjORbj merged 2 commits intomainfrom
devin/1770735192-routing-form-identifier-hint
Feb 20, 2026
Merged

fix: update routing form identifier hint text with learn more link#27837
hbjORbj merged 2 commits intomainfrom
devin/1770735192-routing-form-identifier-hint

Conversation

@CarinaWolli
Copy link
Member

@CarinaWolli CarinaWolli commented Feb 10, 2026

What does this PR do?

Updates the routing form identifier field's info text from "Used for URL parameters, like &name=john" to a more descriptive message with a "Learn more" link pointing to the help article on connecting routing form data to booking questions.

Before:
Screenshot 2026-02-11 at 1 33 52 PM

After:
Screenshot 2026-02-11 at 1 20 05 PM

Changes:

  • Updated the identifier_url_parameter_hint locale string in en/common.json
  • Widened hint prop type on InputFieldProps from string to React.ReactNode so JSX can be passed
  • Replaced the plain text hint with a LearnMoreLink component (same component already used in advanced event type settings) that links to https://cal.com/help/routing/connect-routing-form-to-booking-questions

The LearnMoreLink component already handles self-hosted instances by stripping the link and showing only the text.

Reviewer Notes

  • The hint type widening from stringReact.ReactNode is backward-compatible (string is a valid ReactNode), and TextField.tsx renders {hint} directly in JSX, so no breakage expected. Worth a quick sanity check that no other consumer relies on hint being strictly a string.
  • Only the English locale string is updated. Other locales will continue showing their existing text (without the "Learn more" link) until translated—this is the standard i18n workflow.
  • No visual demo included—reviewer should verify the hint renders correctly with the underlined link styling.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  1. Go to any routing form → edit or create a form field
  2. Look at the "Identifier" field's hint text below the input
  3. Confirm it reads: "For URL parameters that can be used to prefill booking questions, e.g. &name=john. Learn more"
  4. Confirm "Learn more" is an underlined link opening https://cal.com/help/routing/connect-routing-form-to-booking-questions in a new tab
  5. On self-hosted (non-cal.com) instances, the "Learn more" link should not appear—only the text

Link to Devin run: https://app.devin.ai/sessions/ff20e885baab462fb304ec871a9975b1
Requested by: @CarinaWolli

Co-Authored-By: carina@cal.com <c.wollendorfer@me.com>
@CarinaWolli CarinaWolli requested review from a team as code owners February 10, 2026 14:55
@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@graphite-app graphite-app bot added core area: core, team members only consumer labels Feb 10, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@CarinaWolli CarinaWolli marked this pull request as draft February 11, 2026 11:52
@pull-request-size pull-request-size bot added size/M and removed size/S labels Feb 11, 2026
@CarinaWolli CarinaWolli marked this pull request as ready for review February 11, 2026 12:34
Copy link
Contributor

@supalarry supalarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but have comment on type issue:

@github-actions github-actions bot marked this pull request as draft February 12, 2026 12:25
@CarinaWolli CarinaWolli marked this pull request as ready for review February 12, 2026 14:37
@hbjORbj hbjORbj enabled auto-merge (squash) February 20, 2026 10:22
@github-actions
Copy link
Contributor

E2E results are ready!

@hbjORbj hbjORbj merged commit 06f4b25 into main Feb 20, 2026
130 of 133 checks passed
@hbjORbj hbjORbj deleted the devin/1770735192-routing-form-identifier-hint branch February 20, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

consumer core area: core, team members only ready-for-e2e size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants