fix: update routing form identifier hint text with learn more link#27837
Merged
fix: update routing form identifier hint text with learn more link#27837
Conversation
Co-Authored-By: carina@cal.com <c.wollendorfer@me.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
CarinaWolli
commented
Feb 11, 2026
supalarry
previously requested changes
Feb 12, 2026
Contributor
supalarry
left a comment
There was a problem hiding this comment.
Looks good but have comment on type issue:
eunjae-lee
approved these changes
Feb 16, 2026
hbjORbj
approved these changes
Feb 20, 2026
Contributor
E2E results are ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the routing form identifier field's info text from "Used for URL parameters, like &name=john" to a more descriptive message with a "Learn more" link pointing to the help article on connecting routing form data to booking questions.
Before:

After:

Changes:
identifier_url_parameter_hintlocale string inen/common.jsonhintprop type onInputFieldPropsfromstringtoReact.ReactNodeso JSX can be passedLearnMoreLinkcomponent (same component already used in advanced event type settings) that links to https://cal.com/help/routing/connect-routing-form-to-booking-questionsThe
LearnMoreLinkcomponent already handles self-hosted instances by stripping the link and showing only the text.Reviewer Notes
hinttype widening fromstring→React.ReactNodeis backward-compatible (string is a valid ReactNode), andTextField.tsxrenders{hint}directly in JSX, so no breakage expected. Worth a quick sanity check that no other consumer relies onhintbeing strictly a string.Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Link to Devin run: https://app.devin.ai/sessions/ff20e885baab462fb304ec871a9975b1
Requested by: @CarinaWolli