Skip to content

Conversation

@sean-brydon
Copy link
Member

What does this PR do?

Create handler for teams/orgs supports passing in annual billing period when creating

@github-actions github-actions bot added the ❗️ .env changes contains changes to env variables label Feb 12, 2026
@graphite-app graphite-app bot added core area: core, team members only consumer labels Feb 12, 2026
@graphite-app graphite-app bot requested a review from a team February 12, 2026 10:35
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 8 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/features/ee/teams/lib/payments.ts">

<violation number="1" location="packages/features/ee/teams/lib/payments.ts:46">
P2: The team-pricing env-var resolution is duplicated between `getTeamPriceId` and the team branch of `getFixedPrice`. Consider reusing `getTeamPriceId` inside `getFixedPrice` for the non-org case to keep a single source of truth and reduce maintenance risk.</violation>
</file>

<file name="packages/features/ee/organizations/lib/OrganizationPaymentService.ts">

<violation number="1" location="packages/features/ee/organizations/lib/OrganizationPaymentService.ts:222">
P2: Avoid reading `process.env` directly here. Env-derived values should be validated and exposed via a shared config/constants module so this service only consumes typed, normalized values.

(Based on your team's feedback about centralizing env-derived configuration.) [FEEDBACK_USED]</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@github-actions
Copy link
Contributor

Devin AI is addressing Cubic AI's review feedback

A Devin session has been created to address the issues identified by Cubic AI.

View Devin Session

@paragon-review
Copy link

Paragon: tests updated

1 new test and 1 updated test generated for this PR.

New Tests

  • extractBillingDataFromStripeSubscription tests — Tests for extractBillingDataFromStripeSubscription covering: yearly interval maps to ANNUALLY, monthly interval maps to MONTHLY, missing recurring defaults to MONTHLY, extraction of pricePerSeat/paidSeats/dates, null and missing values, trial_end handling, items as array vs object with data property

Updated Tests

  • payments.test.ts - add getTeamPriceId error and annual price calculation tests — Adding new test to existing file

Accept Changes Open in Paragon

Details

New Tests

  • extractBillingDataFromStripeSubscription tests (unit)

Updated Tests

  • payments.test.ts - add getTeamPriceId error and annual price calculation tests (unit)

@eunjae-lee eunjae-lee enabled auto-merge (squash) February 12, 2026 13:59
@eunjae-lee eunjae-lee merged commit 98ec38a into main Feb 12, 2026
86 of 87 checks passed
@eunjae-lee eunjae-lee deleted the feat/support-annual-plans-via-service branch February 12, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

consumer core area: core, team members only ❗️ .env changes contains changes to env variables ready-for-e2e size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants