fix: Correct hours-to-days conversion in convertToNewDurationType#27964
Merged
romitg2 merged 3 commits intocalcom:mainfrom Feb 15, 2026
Merged
fix: Correct hours-to-days conversion in convertToNewDurationType#27964romitg2 merged 3 commits intocalcom:mainfrom
romitg2 merged 3 commits intocalcom:mainfrom
Conversation
Signed-off-by: Aritra Dey <adey01027@gmail.com>
3 tasks
Member
|
@AritraDey-Dev avoid updating branch once i've added |
Contributor
Author
|
sorry about that, I wasn’t aware of that. |
Member
No worries, Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
hours_daysduration conversion #27963Visual Demo (For contributors especially)
A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).
Video Demo (if applicable):
Image Demo (if applicable):
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Summary by cubic
Fixes the hours-to-days conversion by dividing by 24 so hour inputs return correct day counts. Adds unit tests for minutes/hours/days conversions, rounding up, zero values, and exported constants.
hours_daysduration conversion #27963.Written for commit afa035d. Summary will update on new commits.