fix: correct @ApiProperty types in verified resources outputs#28340
Merged
volnei merged 2 commits intocalcom:mainfrom Mar 10, 2026
Merged
fix: correct @ApiProperty types in verified resources outputs#28340volnei merged 2 commits intocalcom:mainfrom
volnei merged 2 commits intocalcom:mainfrom
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
romitg2
added
run-ci
volnei
approved these changes
Mar 10, 2026
yuvrajangadsingh
pushed a commit
to yuvrajangadsingh/cal.com
that referenced
this pull request
Mar 11, 2026
…#28340) * fix(docs): corrects output response type for verified resources endpoints * fix: udpate oasdiff-err-ignore.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
The @ApiProperty decorators in verified-email.output.ts and verified-phone.output.ts were incorrectly using ScheduleOutput as the type for verified email/phone data properties. This was likely a copy-paste error from when the files were created.
This caused the OpenAPI/Swagger documentation to show schedule-related fields instead of the actual verified email/phone fields for these endpoints:
Solution
Updated the @ApiProperty({ type: ... }) to reference the correct output data classes: