fix: rename OOO controller file to match NestJS Swagger plugin convention#28342
Merged
volnei merged 3 commits intocalcom:mainfrom Mar 10, 2026
Merged
fix: rename OOO controller file to match NestJS Swagger plugin convention#28342volnei merged 3 commits intocalcom:mainfrom
volnei merged 3 commits intocalcom:mainfrom
Conversation
…tion for type generation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
romitg2
added
ready-for-e2e
run-ci
yuvrajangadsingh
pushed a commit
to yuvrajangadsingh/cal.com
that referenced
this pull request
Mar 11, 2026
…tion (calcom#28342) * fix: rename OOO controller file to match NestJS Swagger plugin convention for type generation * fix: update organization module import * feat: generate openapi docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The OOO (Out of Office) controller endpoints were missing response type schemas in the generated OpenAPI spec
Root Cause
The NestJS Swagger CLI plugin uses controllerFileNameSuffix (default: ['.controller.ts']) to identify controller files for AST transformation. The OOO controller was named organizations-users-ooo-controller.ts (using -controller.ts), which didn't match the expected .controller.ts suffix.
This caused the plugin to skip injecting openapi.ApiResponse decorators, resulting in empty response schemas:
responses: { 200: { description: } }
Solution
Renamed the controller file to follow the standard NestJS convention:
This allows the Swagger plugin to properly process the controller and inject response types automatically, eliminating the need for explicit @ApiOkResponse decorators.