fix(e2e): fix false-passing assertions and CI test failures

[dididy]

This PR was opened by mistake. Please refer to #28486.

[cubic-dev-ai]

3 issues found across 20 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/web/playwright/payment-apps.e2e.ts">

<violation number="1" location="apps/web/playwright/payment-apps.e2e.ts:127">
P2: Custom agent: **E2E Tests Best Practices**

Avoid text locators in E2E tests. Add stable data-testid selectors and use `page.getByTestId()` instead of `page.locator("text=...")` to meet E2E test resilience requirements.</violation>

<violation number="2" location="apps/web/playwright/payment-apps.e2e.ts:210">
P2: Custom agent: **E2E Tests Best Practices**

Use `expect(page).toHaveURL()` for navigation assertions to fail fast on unexpected redirects, per E2E test best practices.</violation>
</file>

<file name="apps/web/playwright/change-theme.e2e.ts">

<violation number="1" location="apps/web/playwright/change-theme.e2e.ts:14">
P2: Strict Playwright locator assertion on `toast-success` can fail when multiple success toasts are mounted concurrently.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P2: Custom agent: E2E Tests Best Practices

Use expect(page).toHaveURL() for navigation assertions to fail fast on unexpected redirects, per E2E test best practices.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At apps/web/playwright/payment-apps.e2e.ts, line 210:

<comment>Use `expect(page).toHaveURL()` for navigation assertions to fail fast on unexpected redirects, per E2E test best practices.</comment>

<file context>
@@ -203,12 +203,11 @@ test.describe("Payment app", () => {
-      // Expect "Connect with Alby" to be displayed
-      expect(await page.locator("text=Connect with Alby").first()).toBeTruthy();
+      // Verify navigation to alby setup page occurred
+      await page.waitForURL("**/apps/alby/setup**");
     } finally {
       await cleanupAlbyApp();
</file context>

Suggested change

	await page.waitForURL("**/apps/alby/setup**");
	await expect(page).toHaveURL("**/apps/alby/setup**");

[cubic-dev-ai]

P2: Custom agent: E2E Tests Best Practices

Avoid text locators in E2E tests. Add stable data-testid selectors and use page.getByTestId() instead of page.locator("text=...") to meet E2E test resilience requirements.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At apps/web/playwright/payment-apps.e2e.ts, line 127:

<comment>Avoid text locators in E2E tests. Add stable data-testid selectors and use `page.getByTestId()` instead of `page.locator("text=...")` to meet E2E test resilience requirements.</comment>

<file context>
@@ -123,15 +123,15 @@ test.describe("Payment app", () => {
-    // expect 200 sats to be displayed in page
-    expect(await page.locator("text=350").first()).toBeTruthy();
+    // expect 350 USD to be displayed in page
+    await expect(page.locator("text=350").first()).toBeVisible();
 
     await selectFirstAvailableTimeSlotNextMonth(page);
</file context>

[cubic-dev-ai]

P2: Strict Playwright locator assertion on toast-success can fail when multiple success toasts are mounted concurrently.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At apps/web/playwright/change-theme.e2e.ts, line 14:

<comment>Strict Playwright locator assertion on `toast-success` can fail when multiple success toasts are mounted concurrently.</comment>

<file context>
@@ -11,8 +11,7 @@ test.describe("Change App Theme Test", () => {
 
-    const toast = await page.waitForSelector('[data-testid="toast-success"]');
-    expect(toast).toBeTruthy();
+    await expect(page.getByTestId("toast-success")).toBeVisible();
 
     const darkModeClass = await page.getAttribute("html", "class");
</file context>