Feature: Routing Forms Typeform App and other improvements#3625
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
hariombalhara
force-pushed
the
improvements/routing-forms
branch
from
e3fa439 to
0d213d8
Compare
hariombalhara
force-pushed
the
improvements/routing-forms
branch
from
b4024ae to
ce0e21b
Compare
hariombalhara
force-pushed
the
improvements/routing-forms
branch
from
ce0e21b to
e79b120
Compare
zomars
reviewed
Aug 1, 2022
6 tasks
zomars
reviewed
Aug 12, 2022
zomars
suggested changes
Aug 12, 2022
Comment on lines
58
to
62
| <div className="mr-5"> | ||
| <img className="h-11" src="/api/app-store/zapier/icon.svg" alt="Zapier Logo" /> | ||
| <img className="h-11" src="/api/app-store/typeform/icon.svg" alt="Zapier Logo" /> | ||
| </div> | ||
| <div className="ml-5"> | ||
| <div className="text-gray-600">{t("setting_up_zapier")}</div> | ||
| <div className="text-gray-600">How to integrate a Typeform with Routing Form</div> | ||
| {!newApiKey ? ( |
Contributor
There was a problem hiding this comment.
This is still on zapier/pages is this intended?
Contributor
There was a problem hiding this comment.
You didn't answer my question before resolving. Is putting the typeform text and icon in the Zapier page and intended change? @hariombalhara
Comment on lines
+19653
to
+19657
| react-hook-form@^7.16.2: | ||
| version "7.34.0" | ||
| resolved "https://registry.yarnpkg.com/react-hook-form/-/react-hook-form-7.34.0.tgz#22883b5e014e5c5e35f3061d0e3862153b0df2ec" | ||
| integrity sha512-s0/TJ09NVlEk2JPp3yit1WnMuPNBXFmUKEQPulgDi9pYBw/ZmmAFHe6AXWq73Y+kp8ye4OcMf0Jv+i/qLPektg== | ||
|
|
Contributor
There was a problem hiding this comment.
We already have 7.31.1 below, let's try to match that
12 tasks
zomars
approved these changes
Aug 13, 2022
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Demo Loom
Fixes #3619 #3559
Environment: Production
Type of change
How should this be tested?