Skip to content

fix: css for location#3744

Merged
zomars merged 9 commits intocalcom:mainfrom
Udit-takkar:fix/location
Aug 15, 2022
Merged

fix: css for location#3744
zomars merged 9 commits intocalcom:mainfrom
Udit-takkar:fix/location

Conversation

@Udit-takkar
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar commented Aug 8, 2022

Fixes #3741

Screenshot 2022-08-08 at 9 10 06 PM

  • made css consistent for location text
  • aligned center icon and locations(if multiple locations are present)

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 8, 2022

@Udit-takkar is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

leog
leog previously requested changes Aug 8, 2022
Copy link
Copy Markdown
Contributor

@leog leog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution @Udit-takkar.

Please take a look at the icon position when there are more than one line of text.

For recurring it looks like this:

@Udit-takkar
Copy link
Copy Markdown
Contributor Author

Screenshot 2022-08-09 at 3 03 17 AM

@Udit-takkar Udit-takkar requested a review from leog August 8, 2022 21:47
@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ❌ Failed (Inspect) Aug 12, 2022 at 7:24PM (UTC)
cal-com ❌ Failed (Inspect) Aug 12, 2022 at 7:24PM (UTC)
nightly-cal ❌ Failed (Inspect) Aug 12, 2022 at 7:24PM (UTC)
swagger ❌ Failed (Inspect) Aug 12, 2022 at 7:24PM (UTC)

Copy link
Copy Markdown
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution 🙏

@kodiakhq
Copy link
Copy Markdown
Contributor

kodiakhq Bot commented Aug 12, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@Udit-takkar
Copy link
Copy Markdown
Contributor Author

resolved merge conflict

@Udit-takkar
Copy link
Copy Markdown
Contributor Author

Udit-takkar commented Aug 15, 2022

@zomars i think you would have to add auto-merge tag

@zomars zomars merged commit c644a10 into calcom:main Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

♻️ autoupdate tells kodiak to keep this branch up-to-date

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Locations has the wrong display on AvailabilityPage

3 participants