fix: add required property on input#3934
Conversation
|
@Udit-takkar is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
awesome work! super fast.👏 @hariombalhara can you review and approve this? |
emrysal
left a comment
There was a problem hiding this comment.
Also have a look at using zod in the book/event endpoint; could be helpful
|
@emrysal where exactly can zod be helpful in 'book/event endpoint'. i think it is already being used at the start |
hariombalhara
left a comment
There was a problem hiding this comment.
I left a comment that needs to be addressed before the merge.
Also, there is a cleaner way to do it using zod, which allows schema validation to work for frontend as well as backend with a single definition. See zodResolver usage in BookingPage.tsx. I wouldn't consider this a blocker for merge but it is good to have.
Thanks again for your contribution @Udit-takkar
Zod changes are done & required behaviour is as intended on checkboxes (e.g. I agree to the terms & conditions)
emrysal
left a comment
There was a problem hiding this comment.
Excellent PR - thanks for the contribution and follow ups! 👍
Fixes: #3918
Also added checks in /api/book if required customInputs are missing.
Loom Video:- https://www.loom.com/share/01ff8da8e2764a1691f23572a37344a6