Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PeerRich
commented
Sep 6, 2022
PeerRich
commented
Sep 6, 2022
| name: "workflows", | ||
| href: "/workflows", | ||
| icon: Icon.FiZap, | ||
| pro: true, |
Member
Author
There was a problem hiding this comment.
workflows won't be pro only in 2.0 @CarinaWolli
PeerRich
commented
Sep 6, 2022
Comment on lines
+533
to
+539
| <MobileNavigationItem | ||
| item={{ | ||
| name: "more", | ||
| href: "/more", | ||
| icon: Icon.FiMoreHorizontal, | ||
| }} | ||
| /> |
Member
Author
There was a problem hiding this comment.
this was my best guess at adding a "more" icon without adding it to the desktop navigation. not sure if this is the best approach but it works
Contributor
There was a problem hiding this comment.
This one. You should be sleeping mate
Contributor
There was a problem hiding this comment.
Made some adjustments, routing forms shouldn't display if not installed
PeerRich
commented
Sep 6, 2022
Comment on lines
-554
to
-562
| itemIdx === 0 ? "rounded-l-lg" : "", | ||
| itemIdx === navigation.length - 1 ? "rounded-r-lg" : "", | ||
| "group relative min-w-0 flex-1 overflow-hidden bg-white py-2 px-2 text-center text-xs font-medium text-neutral-400 hover:bg-gray-50 hover:text-gray-700 focus:z-10 sm:text-sm [&[aria-current='page']]:text-gray-900" |
Member
Author
There was a problem hiding this comment.
we dont need this in the new bottom nav
alannnc
reviewed
Sep 7, 2022
| const desktopNavigationItems: NavigationItemType[] = []; | ||
| const mobileNavigationBottomItems: NavigationItemType[] = []; | ||
| const mobileNavigationMoreItems: NavigationItemType[] = []; | ||
| navigation.forEach((item, index) => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CleanShot.2022-09-06.at.22.37.46.mp4