Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PeerRich
reviewed
Sep 7, 2022
PeerRich
approved these changes
Sep 7, 2022
Member
PeerRich
left a comment
PeerRich
left a comment
There was a problem hiding this comment.
great stuff. love that new admin check component
Member
Author
|
@zomars could you sanity check this admin component before we merge? |
zomars
reviewed
Sep 7, 2022
zomars
reviewed
Sep 7, 2022
zomars
suggested changes
Sep 7, 2022
Contributor
zomars
left a comment
zomars
left a comment
There was a problem hiding this comment.
Blocking until feedback is addressed
Member
|
related: #4270 it seems like all admin settings are visible to non-admins (backend still checks for permission luckily) |
Member
Author
Member
Author
|
@zomars this creates a content flash if you are not an admin (if you manually navigate to an admin page) - not 100% sure the best way to prevent that do you have any ideas? |
zomars
approved these changes
Sep 8, 2022
PeerRich
added
♻️ autoupdate
Contributor
|
Not ideal but let's follow up instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds impersonate UI to settings
Also adds a new permission container