Skip to content

fixes toggle#4253

Merged
PeerRich merged 12 commits intomainfrom
fix/4245-toggle-start
Sep 8, 2022
Merged

fixes toggle#4253
PeerRich merged 12 commits intomainfrom
fix/4245-toggle-start

Conversation

@agustif
Copy link
Copy Markdown
Contributor

@agustif agustif commented Sep 7, 2022

What does this PR do?

Fixes #4245

Type of change

image

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Go to a recurring event, checkbox should stay on top and not move down now

@vercel
Copy link
Copy Markdown

vercel bot commented Sep 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Sep 8, 2022 at 9:03AM (UTC)

@agustif agustif requested a review from a team September 7, 2022 18:23
@agustif agustif added ♻️ autoupdate tells kodiak to keep this branch up-to-date 👀 ready for review automerge labels Sep 7, 2022
Comment thread apps/web/components/eventtype/RecurringEventController.tsx Outdated
Copy link
Copy Markdown
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont use absolute, instead stay in flex but move the switch into the headline container

@agustif
Copy link
Copy Markdown
Contributor Author

agustif commented Sep 7, 2022

yeah removed that absolute as it wasn't needed, forgot to remove it from previous testing, fixed it now!

@PeerRich PeerRich enabled auto-merge (squash) September 8, 2022 08:55
@PeerRich
Copy link
Copy Markdown
Member

PeerRich commented Sep 8, 2022

great stuff, thanks!

@PeerRich PeerRich added the ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work label Sep 8, 2022
@PeerRich PeerRich disabled auto-merge September 8, 2022 09:42
@PeerRich PeerRich enabled auto-merge (squash) September 8, 2022 09:42
@PeerRich PeerRich disabled auto-merge September 8, 2022 09:42
@PeerRich PeerRich merged commit 38bd111 into main Sep 8, 2022
@PeerRich PeerRich deleted the fix/4245-toggle-start branch September 8, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

/event-type-detail /recurring - toggle goes down a row when active

3 participants