Skip to content

added padding top for settings on desktop#4280

Merged
PeerRich merged 6 commits intomainfrom
4271-desktop-app-settings-needs-padding-top
Sep 8, 2022
Merged

added padding top for settings on desktop#4280
PeerRich merged 6 commits intomainfrom
4271-desktop-app-settings-needs-padding-top

Conversation

@PeerRich
Copy link
Copy Markdown
Member

@PeerRich PeerRich commented Sep 8, 2022

to test, add "todesktop" to body: <body class="todesktop">

before

CleanShot 2022-09-08 at 13 35 39@2x

after
CleanShot 2022-09-08 at 13 33 01@2x

@PeerRich PeerRich linked an issue Sep 8, 2022 that may be closed by this pull request
@vercel
Copy link
Copy Markdown

vercel bot commented Sep 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Sep 8, 2022 at 5:09PM (UTC)

@PeerRich PeerRich enabled auto-merge (squash) September 8, 2022 11:36
@PeerRich PeerRich self-assigned this Sep 8, 2022
@PeerRich PeerRich added ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge labels Sep 8, 2022
@PeerRich PeerRich added this to the v.2.0 milestone Sep 8, 2022
@kodiakhq
Copy link
Copy Markdown
Contributor

kodiakhq bot commented Sep 8, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@PeerRich PeerRich requested a review from joeauyeung September 8, 2022 16:35
Copy link
Copy Markdown
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

Copy link
Copy Markdown
Contributor

@agustif agustif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Loving our -native- app looks

@PeerRich PeerRich disabled auto-merge September 8, 2022 17:34
@PeerRich PeerRich merged commit d7ec335 into main Sep 8, 2022
@PeerRich PeerRich deleted the 4271-desktop-app-settings-needs-padding-top branch September 8, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

desktop app: /settings needs padding top

3 participants