Skip to content

routing forms: first iteration of fixing dark mode#4304

Merged
PeerRich merged 5 commits intomainfrom
4030-embeds-force-light-mode-since-we-dont-have-dark-inputs-yet
Sep 8, 2022
Merged

routing forms: first iteration of fixing dark mode#4304
PeerRich merged 5 commits intomainfrom
4030-embeds-force-light-mode-since-we-dont-have-dark-inputs-yet

Conversation

@PeerRich
Copy link
Copy Markdown
Member

@PeerRich PeerRich commented Sep 8, 2022

before

CleanShot 2022-09-08 at 18 27 19@2x

after

CleanShot 2022-09-08 at 18 27 48@2x


dark mode for <Select> is still missing

@PeerRich PeerRich linked an issue Sep 8, 2022 that may be closed by this pull request
@vercel
Copy link
Copy Markdown

vercel bot commented Sep 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Sep 8, 2022 at 5:42PM (UTC)

@PeerRich PeerRich added ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work labels Sep 8, 2022
Copy link
Copy Markdown
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boat ship it GIF

Copy link
Copy Markdown
Contributor

@agustif agustif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@PeerRich PeerRich merged commit 4771a1a into main Sep 8, 2022
@PeerRich PeerRich deleted the 4030-embeds-force-light-mode-since-we-dont-have-dark-inputs-yet branch September 8, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

routing forms embeds: fix dark mode

3 participants