Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sean-brydon
previously requested changes
Sep 8, 2022
Member
sean-brydon
left a comment
sean-brydon
left a comment
There was a problem hiding this comment.
LGTM - few NITS but I did it for you pretty much <3
| const query = trpc.useQuery(["viewer.availability.list"]); | ||
|
|
||
| return ( | ||
| <QueryCell |
Member
There was a problem hiding this comment.
NIT: To my understanding we are trying to move away from Query Cell? @zomars
Member
There was a problem hiding this comment.
is this a blocker? @zomars @emrysal @sean-brydon
if not lets merge
Member
There was a problem hiding this comment.
I don't believe so @PeerRich - We still use it across the app. New issue should be created to remove query cell if we are planning to not use it anymore however
Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com>
Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com>
Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com>
Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com>
PeerRich
added
♻️ autoupdate
Contributor
Author
|
@sean-brydon All addressed |
Contributor
|
@sean-brydon can we have your approval so we can get this merged? Code looks good to me but haven't tested |
Member
|
@baileypumfleet Looks good to me - design wise is perfect :) It works thats a bonus |
joeauyeung
pushed a commit
that referenced
this pull request
Sep 9, 2022
* Add Availability Tab * Some i18n fixups * Update apps/web/components/v2/eventtype/AvailabilityTab.tsx Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com> * Update apps/web/components/v2/eventtype/AvailabilityTab.tsx Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com> * Update apps/web/components/v2/eventtype/AvailabilityTab.tsx Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com> * Update apps/web/components/v2/eventtype/AvailabilityTab.tsx Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com> * Fixed lint * Oops * Use classnames for SkeletonText instead of width,height * Ditches QueryCell Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #4288