fix: position of badges#4657
Merged
Merged
Conversation
|
@Udit-takkar is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Member
Member
|
We should definitely show the label on mobile. As well as the date & time. We have designs for this here. It would be great to also test this with recurring bookings. |
Contributor
Author
|
ok |
Contributor
Author
Contributor
Author
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PeerRich
reviewed
Sep 24, 2022
Member
|
@Udit-takkar left a comment re: not using |
auto-merge was automatically disabled
September 24, 2022 17:22
Head branch was pushed to by a user without write access
Contributor
Author
|
done |
PeerRich
approved these changes
Sep 24, 2022
Member
PeerRich
left a comment
There was a problem hiding this comment.
great stuff! thank you @Udit-takkar
Contributor
|
Just a FYI @Udit-takkar @PeerRich this PR is what currently breaking our E2E tests. We're introducing duplicate markdown and displaying it with breakpoints and Playwright doesn't like that. |
zomars
reviewed
Sep 29, 2022
Comment on lines
+368
to
+379
| <div className="flex justify-end sm:hidden"> | ||
| <div className="whitespace-nowrap pt-2 pb-4 text-right text-sm font-medium ltr:pr-4 rtl:pl-4"> | ||
| {isUpcoming && !isCancelled ? ( | ||
| <> | ||
| {isPending && user?.id === booking.user?.id && <TableActions actions={pendingActions} />} | ||
| {isConfirmed && <TableActions actions={bookedActions} />} | ||
| {isRejected && <div className="text-sm text-gray-500">{t("rejected")}</div>} | ||
| </> | ||
| ) : null} | ||
| {isPast && isPending && !isConfirmed ? <TableActions actions={bookedActions} /> : null} | ||
| </div> | ||
| </div> |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





fixes: #4649