Ensure currentUsername is set before comparing it with username#4750
Merged
Ensure currentUsername is set before comparing it with username#4750
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hariombalhara
force-pushed
the
fix-username-availability-issue
branch
from
a3421a9 to
b853d23
Compare
zomars
approved these changes
Sep 29, 2022
alannnc
approved these changes
Sep 29, 2022
Contributor
alannnc
left a comment
alannnc
left a comment
There was a problem hiding this comment.
I did once run on this error and looks like the fix worked.
NIT: @hariombalhara
On first render I'm able to see this text on yellow appears and then it's gone.
"You need to reserve your premium username for ..."
I don't know when it's triggering but can we add a flag to don't show? Till it's needed.
…ame-availability-issue
…lcom/cal.com into fix-username-availability-issue
…ame-availability-issue
zomars
added
♻️ autoupdate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #4749
Environment: Production
Type of change
How should this be tested?
Checklist