Skip to content

#4445: Fix to prevent bookings with long titles or a lot of content from overflowing on the page#4769

Merged
pumfleet merged 3 commits intomainfrom
fix/4445-bookings-off-screen
Sep 30, 2022
Merged

#4445: Fix to prevent bookings with long titles or a lot of content from overflowing on the page#4769
pumfleet merged 3 commits intomainfrom
fix/4445-bookings-off-screen

Conversation

@JeroenReumkens
Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes overflowing on booking page when event has a long title or there's a lot of other content on the page. We removed the truncation (...) of the text and made the text go to the next line.

Fixes #4445

Before:

CleanShot 2022-09-29 at 20 34 58@2x

CleanShot 2022-09-29 at 20 35 18@2x

CleanShot 2022-09-29 at 20 35 35@2x

New situation

CleanShot 2022-09-30 at 08 59 26@2x

CleanShot 2022-09-30 at 08 59 52@2x

CleanShot 2022-09-30 at 09 00 14@2x

Environment: Staging(main branch)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Ensure that content on /booking isn't overflowing anymore with different types of titles. Also check multiple tabs on this page.

@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Sep 30, 2022 at 10:45AM (UTC)

Copy link
Copy Markdown
Contributor

@pumfleet pumfleet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me :)

@zomars zomars added ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge labels Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

/bookings - Going off screen

3 participants