Skip to content

fixed dropdown in safari#4828

Merged
emrysal merged 4 commits intomainfrom
4377-v2-when-href-is-applied-to-dropdown-menu-item-styling-is-wrong
Oct 4, 2022
Merged

fixed dropdown in safari#4828
emrysal merged 4 commits intomainfrom
4377-v2-when-href-is-applied-to-dropdown-menu-item-styling-is-wrong

Conversation

@PeerRich
Copy link
Copy Markdown
Member

@PeerRich PeerRich commented Oct 4, 2022

TIL: turns out safari doesnt like the <a> styling. it's now a button with router.push

before
CleanShot 2022-10-04 at 16 26 14@2x

after

CleanShot 2022-10-04 at 16 26 32@2x

@PeerRich PeerRich linked an issue Oct 4, 2022 that may be closed by this pull request
@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Oct 4, 2022 at 3:44PM (UTC)

@emrysal emrysal enabled auto-merge (squash) October 4, 2022 15:33
@emrysal emrysal added ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge labels Oct 4, 2022
@emrysal emrysal merged commit 9d911cb into main Oct 4, 2022
@emrysal emrysal deleted the 4377-v2-when-href-is-applied-to-dropdown-menu-item-styling-is-wrong branch October 4, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

V2 - When href is applied to dropdown menu item styling is wrong

2 participants