Feat/3334 show times in timezones for bookingpage by JeroenReumkens · Pull Request #4971 · calcom/cal.diy

JeroenReumkens · 2022-10-12T11:51:17Z

What does this PR do?

Adds a popup/tooltip to view the meeting time in the different timezones of all attendees.

Behaviour:

Only shows unique timezones, doesn't show duplicates
If everyone is in the same timezone popup won't show
Timezones are sorted by their GMT timezone (earliest to latest)
If someone meets a day before / after we show -1 / +1
As discussed with Ciaran we don't show avatars for now

Fixes #3334

https://www.loom.com/share/2caee7c38aa74a588f83ccec9af5672b

Environment: Staging(main branch)

Type of change

New feature (non-breaking change which adds functionality)

How should this be tested?

Create different meetings and verify that the popup shows the correct times in the respective timezones.

vercel · 2022-10-12T11:51:20Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
cal	✅ Ready (Inspect)	Visit Preview	Oct 19, 2022 at 9:43AM (UTC)

…gpage

CarinaWolli · 2022-10-18T15:13:40Z

@JeroenReumkens I just tested it and it shows +1, even when it is the same day:

JeroenReumkens · 2022-10-18T15:21:05Z

@CarinaWolli Thanks for testing!! Very weird, I will check it! 🙏

leog · 2022-10-18T15:21:23Z

@JeroenReumkens I was testing it in https://cal-auu1mnfp0-cal.vercel.app/bookings/upcoming and clicking in the popover was actually sending me to the booking success page 🤔

JeroenReumkens · 2022-10-18T15:25:14Z

@leog Thanks, will also retest that tomorrow! In theory this line should prevent that, but then it doesn't seem to do that according to your tests 🤔 Will recheck.

zomars · 2022-10-18T17:59:34Z

@JeroenReumkens let's also do a self-review from now.

…agation on popover

alannnc · 2022-10-18T18:09:21Z

  const location = booking.location || "";

-  const onClick = () => {
+  const onClickTableData = (ev: React.MouseEvent<HTMLDivElement>) => {


@JeroenReumkens Renamed to better understanding and don't collide with onClick.

@alannnc Cool! Main reason I added it in here instead of the default behavior of the Popover is because the click behavior is actually something the BookingListItem tries to control, and not something the Popover should know about. But I sticked with your suggestion and added it to the tooltip button as well. Abstracted it to a function to so I could add a comment as to why this is needed 👍

alannnc

Code works now.
NIT: What do you think of adding this so you know which one is yours.

…-show-times-in-timezones-for-bookingpage

…gpage

zomars

…gpage

Co-authored-by: alannnc <alannnc@gmail.com>

…click bubbling to row click.

…as per their own instructions.

… compared agains a date instead of time. Also improved sortbytimezone util by making use of utcoffset helper from dayjs.

JeroenReumkens · 2022-10-19T07:06:30Z

Fixes mentioned in PR are done. Also make the sortByTimezone function simpler by utilising the utcOffset in dayjs, which I did not discover during my search for something like this before 😅

@CarinaWolli There indeed was a bug in comparing prev / next day 🙏 Thanks so much for discovering this. This is fixed now. Could you please retest it?

@leog Clicking the popup content now doesn't redirect you to the detail page anymore 😄 Thanks for spotting that, I actually only tested clicking the button, not the content I realised! Could you please retest?

@alannnc I reverted your date format change for #5050 as you told me to. I did NOT revert all the other changes in that PR, was that actually the plan?

Thanks all!

…gpage

Co-authored-by: alannnc <alannnc@gmail.com> Co-authored-by: Alan <alannnc@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

JeroenReumkens added 3 commits October 12, 2022 09:22

#3334 Show times in all attendees timezones on booking overview page.

6bd7127

Show -1 or +1 in timezones time popup if time is in next of prev day.

6f39f84

Fix gmt sorting.

4e21d5a

JeroenReumkens requested a review from a team October 12, 2022 11:51

vercel Bot deployed to Preview October 12, 2022 11:53 View deployment

Merge branch 'main' into feat/3334-show-times-in-timezones-for-bookin…

afb91ae

…gpage

JeroenReumkens requested a review from ciaranha October 17, 2022 06:36

vercel Bot deployed to Preview October 17, 2022 06:40 View deployment

JeroenReumkens added 3 commits October 18, 2022 16:21

Merge branch 'main' into feat/3334-show-times-in-timezones-for-bookin…

693ea09

…gpage

undo file formatting

af751a4

undo file formatting

8574513

JeroenReumkens self-assigned this Oct 18, 2022

vercel Bot deployed to Preview October 18, 2022 14:40 View deployment

alannnc added 2 commits October 18, 2022 12:07

Updated function name to don't collide with reserved, added stop prop…

6fbb3d3

…agation on popover

Removed unused arg

e4d9f52

alannnc reviewed Oct 18, 2022

View reviewed changes

Comment thread packages/ui/v2/core/MeetingTimeInTimezones.tsx Outdated

alannnc reviewed Oct 18, 2022

View reviewed changes

Comment thread packages/lib/date-fns/index.ts

vercel Bot deployed to Preview October 18, 2022 18:21 View deployment

alannnc approved these changes Oct 18, 2022

View reviewed changes

Merge branch 'main' of ssh://github.com/calcom/cal.com into feat/3334…

d5aa637

…-show-times-in-timezones-for-bookingpage

vercel Bot deployed to Preview October 18, 2022 18:50 View deployment

Merge branch 'main' into feat/3334-show-times-in-timezones-for-bookin…

8135030

…gpage

alannnc added the ♻️ autoupdate tells kodiak to keep this branch up-to-date label Oct 18, 2022

vercel Bot deployed to Preview October 18, 2022 19:13 View deployment

zomars approved these changes Oct 18, 2022

View reviewed changes

kodiakhq Bot added 4 commits October 18, 2022 19:35

Merge branch 'main' into feat/3334-show-times-in-timezones-for-bookin…

d1ca42e

…gpage

Merge branch 'main' into feat/3334-show-times-in-timezones-for-bookin…

ba9a843

…gpage

Merge branch 'main' into feat/3334-show-times-in-timezones-for-bookin…

d0ac595

…gpage

Merge branch 'main' into feat/3334-show-times-in-timezones-for-bookin…

992f250

…gpage

vercel Bot deployed to Preview October 18, 2022 20:10 View deployment

Merge branch 'main' into feat/3334-show-times-in-timezones-for-bookin…

15b01a1

…gpage

vercel Bot deployed to Preview October 18, 2022 20:44 View deployment

Merge branch 'main' into feat/3334-show-times-in-timezones-for-bookin…

706c1d6

…gpage

vercel Bot deployed to Preview October 18, 2022 23:39 View deployment

Code review tweak

13ff504

Co-authored-by: alannnc <alannnc@gmail.com>

vercel Bot deployed to Preview October 19, 2022 06:26 View deployment

#3334; Added stoppropagation to meeting timezones popover to prevent …

dc7fcbb

…click bubbling to row click.

vercel Bot deployed to Preview October 19, 2022 06:34 View deployment

Reverting Alex's time format changes on the booking page done in #5050 …

a6f48a3

…as per their own instructions.

vercel Bot deployed to Preview October 19, 2022 06:43 View deployment

Fixed utils checking if time in other timezone is next/prev day, they…

2efe648

… compared agains a date instead of time. Also improved sortbytimezone util by making use of utcoffset helper from dayjs.

JeroenReumkens requested review from CarinaWolli and leog October 19, 2022 07:07

vercel Bot deployed to Preview October 19, 2022 07:12 View deployment

Merge branch 'main' into feat/3334-show-times-in-timezones-for-bookin…

65393d5

…gpage

vercel Bot deployed to Preview October 19, 2022 09:43 View deployment

PeerRich enabled auto-merge (squash) October 19, 2022 09:45

PeerRich merged commit 373c255 into main Oct 19, 2022

PeerRich deleted the feat/3334-show-times-in-timezones-for-bookingpage branch October 19, 2022 09:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/3334 show times in timezones for bookingpage#4971

Feat/3334 show times in timezones for bookingpage#4971
PeerRich merged 22 commits intomainfrom
feat/3334-show-times-in-timezones-for-bookingpage

JeroenReumkens commented Oct 12, 2022 •

edited

Loading

Uh oh!

vercel Bot commented Oct 12, 2022 •

edited

Loading

Uh oh!

CarinaWolli commented Oct 18, 2022

Uh oh!

JeroenReumkens commented Oct 18, 2022

Uh oh!

leog commented Oct 18, 2022

Uh oh!

JeroenReumkens commented Oct 18, 2022

Uh oh!

zomars commented Oct 18, 2022

Uh oh!

alannnc Oct 18, 2022

Uh oh!

JeroenReumkens Oct 19, 2022

Uh oh!

Uh oh!

Uh oh!

alannnc left a comment

Uh oh!

zomars left a comment

Uh oh!

JeroenReumkens commented Oct 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

JeroenReumkens commented Oct 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Behaviour:

Type of change

How should this be tested?

Uh oh!

vercel Bot commented Oct 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CarinaWolli commented Oct 18, 2022

Uh oh!

JeroenReumkens commented Oct 18, 2022

Uh oh!

leog commented Oct 18, 2022

Uh oh!

JeroenReumkens commented Oct 18, 2022

Uh oh!

zomars commented Oct 18, 2022

Uh oh!

alannnc Oct 18, 2022

Choose a reason for hiding this comment

Uh oh!

JeroenReumkens Oct 19, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

alannnc left a comment

Choose a reason for hiding this comment

Uh oh!

zomars left a comment

Choose a reason for hiding this comment

Uh oh!

JeroenReumkens commented Oct 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

JeroenReumkens commented Oct 12, 2022 •

edited

Loading

vercel Bot commented Oct 12, 2022 •

edited

Loading