feat: Improve edit availability workflow#5159
Merged
emrysal merged 16 commits intocalcom:mainfrom Nov 3, 2022
Merged
Conversation
…schedule" query resolver.
… availability if it's changed.
|
@G3root is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
JeroenReumkens
previously requested changes
Nov 2, 2022
Contributor
JeroenReumkens
left a comment
JeroenReumkens
left a comment
There was a problem hiding this comment.
Nice! This works perfectly, tested it locally as well 🙏
One small request to add a comment. Apart from that really happy with it.
I also verified that it updates data on other pages without refreshing 👍
Any other remarks @emrysal ?
JeroenReumkens
added
the
♻️ autoupdate
Contributor
|
Thanks @G3root! Awesome change 🙏 |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
haffla
pushed a commit
to tourlane/cal.com
that referenced
this pull request
Nov 22, 2022
* feat: return data fromsetupDefaultSchedule * feat: update returned data of "schedule.update" resolver as same as "schedule" query resolver. * feat: set query data from updated results and invalidate prev default availability if it's changed. * chore: add comments Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
this PR improves workflow of editing a availability. currently users are redirected when an availability schedule is edited, this PR improve aims to increase the UX without redirecting the user.
https://www.loom.com/share/702a021d380b4dfabf398af652fc3875
Type of change