Adds number for sms notifications from workflows to /success#5210
Adds number for sms notifications from workflows to /success#5210CarinaWolli merged 7 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JeroenReumkens
left a comment
JeroenReumkens
left a comment
There was a problem hiding this comment.
Works perfect! Only need to do something about the duplicate translation I think. Apart from that ready to approve!
| "no_event_types": "No event types setup", | ||
| "no_event_types_description": "{{name}} has not setup any event types for you to book." | ||
| "no_event_types_description": "{{name}} has not setup any event types for you to book.", | ||
| "number_sms_notifications": "Phone number (SMS notifications)" |
There was a problem hiding this comment.
Is it hacky to propose adding a non breaking space (\u00a0) between the words SMS and notifications? This will make them "one word" and add the line break after "number". That visually just looks a bit nicer 😁
There was a problem hiding this comment.
Wouldn't it be better if we structure it better by moving SMS notifications to a separate tag. That would also allow it to be styled differently(may be a little less bold and lighter color?)
There was a problem hiding this comment.
Good idea. Let's ask @Jaibles their opinion, since adding additional blocks might also make this look more "chaotic".
pumfleet
left a comment
pumfleet
left a comment
There was a problem hiding this comment.
Looks good to me, pending the comments related to the translation strings
|
Looks great to me now @CarinaWolli |
hariombalhara
added
♻️ autoupdate
…5210) * add sms notification phone number to success page * remove duplicate translation * add non breaking space between sms and notifications Co-authored-by: CarinaWolli <wollencarina@gmail.com> Co-authored-by: Bailey Pumfleet <pumfleet@hey.com>
…5210) * add sms notification phone number to success page * remove duplicate translation * add non breaking space between sms and notifications Co-authored-by: CarinaWolli <wollencarina@gmail.com> Co-authored-by: Bailey Pumfleet <pumfleet@hey.com>
5 participants
What does this PR do?
Fixes #4813 (#4813 (comment))
Environment: Staging(main branch)
How should this be tested?