Send Email to Owner on Form Submission#5261
Merged
hariombalhara merged 7 commits intomainfrom Nov 3, 2022
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hariombalhara
force-pushed
the
feat/email-on-form-response
branch
from
3d4935f to
1378e75
Compare
pumfleet
approved these changes
Oct 28, 2022
Contributor
pumfleet
left a comment
pumfleet
left a comment
There was a problem hiding this comment.
Awesome, thanks for building this!
hariombalhara
force-pushed
the
feat/email-on-form-response
branch
from
e9c306e to
cd88015
Compare
hariombalhara
force-pushed
the
feat/email-on-form-response
branch
from
786d1f3 to
30a8fcf
Compare
hariombalhara
commented
Oct 28, 2022
Member
Author
hariombalhara
left a comment
hariombalhara
left a comment
There was a problem hiding this comment.
Self review done
| }}> | ||
| <p style={{ fontWeight: 400, lineHeight: "24px" }}> | ||
| <a href={`${WEBAPP_URL}/apps/routing-forms/form-edit/${form.id}`} style={{ color: "#3e3e3e" }}> | ||
| <>Manage this form</> |
Member
Author
There was a problem hiding this comment.
@PeerRich What language should this be in? Should this be the language configured by the person who created the form? or english would work?
|
|
||
| const fieldResponsesByName: Record<string, typeof response[keyof typeof response]["value"]> = {}; | ||
|
|
||
| for (const [fieldId, fieldResponse] of Object.entries(response)) { |
Member
Author
There was a problem hiding this comment.
Moved this logic to onFormSubmit
| } | ||
|
|
||
| const missingFields = fields | ||
| const serializableFormWithFields = { |
Member
Author
There was a problem hiding this comment.
This creates a type that has fields set unlike serializableForm which has fields optional.
hariombalhara
commented
Oct 28, 2022
| prisma, | ||
| user | ||
| user, | ||
| ssrInit |
Member
Author
There was a problem hiding this comment.
Provides the method that would allow app pages to do translations server side.
hariombalhara
commented
Oct 28, 2022
| export { OrganizerScheduledEmail } from "./OrganizerScheduledEmail"; | ||
| export { TeamInviteEmail } from "./TeamInviteEmail"; | ||
| export { BrokenIntegrationEmail } from "./BrokenIntegrationEmail"; | ||
| export * from "@calcom/app-store/ee/routing-forms/emails/components"; |
Member
Author
There was a problem hiding this comment.
Import all email components here so that renderEmail method supports routing-forms email components as welll
hariombalhara
force-pushed
the
feat/email-on-form-response
branch
from
30a8fcf to
30e533f
Compare
hariombalhara
added
♻️ autoupdate
haffla
pushed a commit
to tourlane/cal.com
that referenced
this pull request
Nov 22, 2022
Co-authored-by: alannnc <alannnc@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #5111
Loom Video: https://www.loom.com/share/52c9fc27b5154cb1a02c154f320bec61
Environment: Production
Type of change
How should this be tested?
Checklist