Guests will be able to add their own location for in person meetings#5282
Conversation
…rson-meetings' of https://github.com/123om123/cal.com into Guests-will-be-able-to-add-their-own-location-for-in-person-meetings
|
@om-ray is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
…n-for-in-person-meetings
|
can you add a loom video? |
…n-for-in-person-meetings
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…n-for-in-person-meetings
|
@PeerRich I'll add one right now! |
|
|
…n-for-in-person-meetings
…n-for-in-person-meetings
@PeerRich Sorry for the late response, I'm working on this right now! |
|
@PeerRich I've fixed the issue you mentioned and would love if you would review the PR! |
CarinaWolli
left a comment
CarinaWolli
left a comment
There was a problem hiding this comment.
Great job so far! I found some issues, that need to be fixed before I can approve.
In addition to the comments, I found one more bug. In the following case I am not able to book the event with Google Meet as the location:
…n-for-in-person-meetings
…rson-meetings' of https://github.com/123om123/cal.com into Guests-will-be-able-to-add-their-own-location-for-in-person-meetings
CarinaWolli
left a comment
CarinaWolli
left a comment
There was a problem hiding this comment.
I found one last thing. We should not show it when editing the location of a booking. So simply filter it out from the location options like we are doing it for the Attendee Phone
…n-for-in-person-meetings
|
@CarinaWolli I'll fix this asap! Thank you for your review! |
…n-for-in-person-meetings
…n-for-in-person-meetings
…n-for-in-person-meetings
…n-for-in-person-meetings
…n-for-in-person-meetings
…n-for-in-person-meetings
emrysal
added
♻️ autoupdate
…n-for-in-person-meetings
…n-for-in-person-meetings
…n-for-in-person-meetings
…alcom#5282) * Guests will be able to add their own location or in person meetings * fix type error * fixed issue with attendees location not showing on success page * google meet booking will now go through, removed unnecessary change * filter out attendee address when editing location Co-authored-by: Peer Richelsen <peeroke@gmail.com>
5 participants
What does this PR do?
Guests can now add their own locations for in-person meetings.
Fixes #5226 and #5192
Environment: Staging(main branch) / Production
Loom:
https://www.loom.com/share/ed59c0a7899441fab6ec60ebeee32b0b
Type of change