Merged
Conversation
…irection by serving default
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PeerRich
approved these changes
Oct 31, 2022
hariombalhara
commented
Oct 31, 2022
Member
Author
hariombalhara
left a comment
hariombalhara
left a comment
There was a problem hiding this comment.
Self review done
hariombalhara
commented
Oct 31, 2022
alannnc
reviewed
Oct 31, 2022
| const username = req.query.username as string; | ||
| const teamname = req.query.teamname as string; | ||
| let identity; | ||
| let linksToThisRoute = false; |
Contributor
There was a problem hiding this comment.
Suggested change
| let linksToThisRoute = false; | |
| let isAvatarSourceWebAppUrl = false; |
Member
Author
There was a problem hiding this comment.
This might not be a better variable name considering it can be WEBSITE_URL
alannnc
reviewed
Oct 31, 2022
alannnc
previously requested changes
Oct 31, 2022
Contributor
alannnc
left a comment
alannnc
left a comment
There was a problem hiding this comment.
Couldn't replicate from instructions, some NIT changes.
hariombalhara
dismissed
alannnc’s stale review
See this loom https://www.loom.com/share/c94e3a07d35c4a8d975fbae012a6fc36.
hariombalhara
added
♻️ autoupdate
haffla
pushed a commit
to tourlane/cal.com
that referenced
this pull request
Nov 22, 2022
* If due to some reason avatar URL is same as route, avoid infinite redirection by serving default * Fix avatar reverting issue Co-authored-by: Peer Richelsen <peeroke@gmail.com> Co-authored-by: alannnc <alannnc@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
haffla
pushed a commit
to tourlane/cal.com
that referenced
this pull request
Nov 22, 2022
* If due to some reason avatar URL is same as route, avoid infinite redirection by serving default * Fix avatar reverting issue Co-authored-by: Peer Richelsen <peeroke@gmail.com> Co-authored-by: alannnc <alannnc@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Contributor
|
The problem with this is that we're exceeding the payload limits due we're returning the whole image as codified data. We should query another endpoint for avatars specifically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5213
Steps to replicate the issue