Skip to content

Fix issue that workflows sometimes need refresh to show updated data#5328

Merged
CarinaWolli merged 2 commits intomainfrom
fix/workflow-refresh
Nov 2, 2022
Merged

Fix issue that workflows sometimes need refresh to show updated data#5328
CarinaWolli merged 2 commits intomainfrom
fix/workflow-refresh

Conversation

@CarinaWolli
Copy link
Copy Markdown
Member

What does this PR do?

Fixes that sometimes the updated data was not shown correctly and a refresh was needed.

Fixes #5274

Bug (before fix): https://www.loom.com/share/084c2bf87df344e2b9a6a15f5a28c52e

After fix: https://www.loom.com/share/b935bed6884b4e588c969f130f2541c1

Environment: Staging(main branch)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Test same as shown in Loom video
  • Test other versions of workflows and see if you see the updated data after saving

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 2, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Nov 2, 2022 at 10:00AM (UTC)

@CarinaWolli CarinaWolli requested a review from a team November 2, 2022 08:54
Copy link
Copy Markdown
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested and seems to be working fine

@JeroenReumkens JeroenReumkens added ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge labels Nov 2, 2022
@CarinaWolli CarinaWolli enabled auto-merge (squash) November 2, 2022 10:03
@CarinaWolli CarinaWolli merged commit 0959cf7 into main Nov 2, 2022
@CarinaWolli CarinaWolli deleted the fix/workflow-refresh branch November 2, 2022 10:06
@what-the-diff
Copy link
Copy Markdown

what-the-diff Bot commented Nov 2, 2022

  • The rounded-r-md class was removed from the button element in TimeTimeUnitInput.tsx
  • In WorkflowPage, a check for form values is no longer performed before setting selectedEventTypes and activeOn to their respective workflow properties

haffla pushed a commit to tourlane/cal.com that referenced this pull request Nov 22, 2022
Co-authored-by: CarinaWolli <wollencarina@gmail.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date core area: core, team members only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-285] Custom Workflow Become Empty after save.

4 participants