Skip to content

fix: add hour12#5349

Merged
kodiakhq[bot] merged 3 commits intomainfrom
fix/event-type
Nov 3, 2022
Merged

fix: add hour12#5349
kodiakhq[bot] merged 3 commits intomainfrom
fix/event-type

Conversation

@Udit-takkar
Copy link
Copy Markdown
Contributor

Fixes: #4885

Screenshot 2022-11-03 at 4 22 22 PM

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Nov 3, 2022 at 0:27AM (UTC)

@what-the-diff
Copy link
Copy Markdown

what-the-diff Bot commented Nov 3, 2022

  • Added useMeQuery hook to get the timeFormat from user's profile
  • Changed format function to accept hour12 as a parameter and pass it in Intl.DateTimeFormat options object
  • Used me query result instead of hardcoded value for 12-hour clock option (timeFormat === 12)

Comment thread apps/web/components/v2/eventtype/AvailabilityTab.tsx Outdated
Copy link
Copy Markdown
Contributor

@JeroenReumkens JeroenReumkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one NIT, besides that awesome change!

@JeroenReumkens JeroenReumkens added the ♻️ autoupdate tells kodiak to keep this branch up-to-date label Nov 3, 2022
@kodiakhq kodiakhq Bot merged commit 328f00a into main Nov 3, 2022
@kodiakhq kodiakhq Bot deleted the fix/event-type branch November 3, 2022 12:28
haffla pushed a commit to tourlane/cal.com that referenced this pull request Nov 22, 2022
* fix: add hour12

* fix: timeformat variable

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Event type availability does not respect 12h/24h account setting.

2 participants