Remove unsupported operators by JSOnLogic#5394
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
hariombalhara
added
♻️ autoupdate
emrysal
approved these changes
Nov 6, 2022
haffla
pushed a commit
to tourlane/cal.com
that referenced
this pull request
Nov 22, 2022
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes Bug: Remove unsupported operators(startsWith and endsWith) by JSONLogic. react-query-awesome-builder supports them but not JSONLogic that we use for rule evaluation.
Found this bug while building reporting for all operators
Containsis still supported and should be enough for now.Environment: Production
Type of change
How should this be tested?
Checklist