Skip to content

team banner#5956

Merged
PeerRich merged 26 commits intomainfrom
5738-cal-474-event-types-teams-promo-banner-on-empty-state-page
Dec 14, 2022
Merged

team banner#5956
PeerRich merged 26 commits intomainfrom
5738-cal-474-event-types-teams-promo-banner-on-empty-state-page

Conversation

@PeerRich
Copy link
Copy Markdown
Member

@PeerRich PeerRich commented Dec 9, 2022 •
edited
Loading

fixes #5738

added initial layout

CleanShot 2022-12-09 at 14 49 04

TODO:

  • needs localStorage
  • needs close button

@PeerRich PeerRich linked an issue Dec 9, 2022 that may be closed by this pull request
[CAL-474] /event types - Teams promo banner on empty state page #5738
Closed
@linear
Copy link
Copy Markdown

linear Bot commented Dec 9, 2022

CAL-474 /event types - Teams promo banner on empty state page

Adds a promo banner to the event types page for people who don't have teams.

↳ Teams promo banner in event types - Cal - New Features (Figma)

  • we already have a cookie for hiding sidebar tips which can be reused: only show if notInTeam

CleanShot 2022-11-28 at 16.59.50@2x.png

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 9, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ❌ Failed (Inspect) Dec 13, 2022 at 9:43PM (UTC)

@PeerRich PeerRich changed the title team banner DRAFT: team banner Dec 9, 2022
@PeerRich
Copy link
Copy Markdown
Member Author

PeerRich commented Dec 9, 2022 •
edited
Loading

still draft, accidentally published undrafted

@PeerRich PeerRich added 🚧 wip / in the making This is currently being worked on teams area: teams, round robin, collective, managed event-types labels Dec 9, 2022
@servusrene
Copy link
Copy Markdown
Contributor

servusrene commented Dec 12, 2022

@PeerRich will it be ready for whitelabel?

@PeerRich
Copy link
Copy Markdown
Member Author

PeerRich commented Dec 12, 2022

@PeerRich will it be ready for whitelabel?

what do you mean? the banner will only be shown on cal.com domains

@servusrene
Copy link
Copy Markdown
Contributor

servusrene commented Dec 12, 2022 •
edited
Loading

@PeerRich will it be ready for whitelabel?

what do you mean? the banner will only be shown on cal.com domains

i also find it useful to provide for /ee/ customers. i would not make it dependent on a domain, instead i would make it dependent on the IS_TEAM_BILLING_ENABLED or HOSTED_CAL_FEATURES variable

@PeerRich
Copy link
Copy Markdown
Member Author

PeerRich commented Dec 12, 2022

@PeerRich will it be ready for whitelabel?

what do you mean? the banner will only be shown on cal.com domains

i also find it useful to provide for /ee/ customers. i would not make it dependent on a domain, instead i would make it dependent on the IS_TEAM_BILLING_ENABLED or HOSTED_CAL_FEATURES variable

im sure /ee/ customers want to whitelabel and not have "Cal.com is better with teams" as a string

@PeerRich PeerRich changed the title DRAFT: team banner team banner Dec 12, 2022
PeerRich
PeerRich commented Dec 12, 2022
View reviewed changes
Comment thread packages/ui/v2/core/Tips.tsx Outdated
@PeerRich PeerRich requested a review from sean-brydon December 12, 2022 10:57
@sean-brydon
Merge branch '5738-cal-474-event-types-teams-promo-banner-on-empty-st…
4d95b26 
…ate-page' of https://github.com/calcom/cal.com into 5738-cal-474-event-types-teams-promo-banner-on-empty-state-page
JeroenReumkens
JeroenReumkens approved these changes Dec 14, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@JeroenReumkens JeroenReumkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now 🫶

@PeerRich PeerRich merged commit 463787b into main Dec 14, 2022
@PeerRich PeerRich deleted the 5738-cal-474-event-types-teams-promo-banner-on-empty-state-page branch December 14, 2022 08:04
zomars added a commit that referenced this pull request Dec 22, 2022
@zomars
Revert "team banner (#5956)"
d5ca121 
This reverts commit 463787b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sean-brydon sean-brydon Awaiting requested review from sean-brydon

@hariombalhara hariombalhara Awaiting requested review from hariombalhara

1 more reviewer

@JeroenReumkens JeroenReumkens JeroenReumkens approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sean-brydon sean-brydon

Labels

automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date teams area: teams, round robin, collective, managed event-types

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CAL-474] /event types - Teams promo banner on empty state page

5 participants

@PeerRich @servusrene @hariombalhara @JeroenReumkens @sean-brydon