#5613 Optimise social images by utilising next image api.#5997
Merged
#5613 Optimise social images by utilising next image api.#5997
Conversation
Contributor
Author
|
@shuding Would also love to hear your opinion about this! I couldn't find any other solution to optimise the images, but this seems to work really well! Thanks 🙏 |
|
Wow this is an interesting usage, looks legit! Ideally the generated image itself should be smaller, we will improve that in future versions. 🙏 |
PeerRich
approved these changes
Dec 13, 2022
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
hariombalhara
left a comment
hariombalhara
left a comment
There was a problem hiding this comment.
This is definitely interesting use of _next 🙌 I wasn't aware of this difference b/w these 2 types of servings.
Left some comments.
pumfleet
approved these changes
Dec 13, 2022
Contributor
pumfleet
left a comment
pumfleet
left a comment
There was a problem hiding this comment.
Aside from Hariom's comments, code looks good to me. Great optimisation!
hariombalhara
approved these changes
Dec 13, 2022
PeerRich
added
♻️ autoupdate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Optimises our OG Images by leveraging Next's Image API. This reduces the image size from 500KB to 80KB 🤯
Fixes #5613
Environment: Staging(main branch)
Type of change
How should this be tested?
The OG meta tag looks like this:
To verify that the link is working you can double click that "content" attribute and copy+paste that url in a new tab. The image should show up 🔥