Skip to content

fix: add allowScroll prop#6215

Merged
PeerRich merged 3 commits intomainfrom
fix/dialog-scroll
Dec 30, 2022
Merged

fix: add allowScroll prop#6215
PeerRich merged 3 commits intomainfrom
fix/dialog-scroll

Conversation

@Udit-takkar
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar commented Dec 29, 2022

Fixes
image

After:
Screenshot 2022-12-29 at 10 39 27 PM

Follow up PR of #6055

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Dec 30, 2022 at 6:15PM (UTC)

? "p-8 sm:max-w-[48rem]"
: "p-8 sm:max-w-[35rem]",
"overflow-y-auto overscroll-auto md:h-auto md:max-h-[inherit]",
"max-h-[560px] overscroll-auto md:h-auto md:max-h-[inherit]",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

max-height is required in case the content in any dialog is too big for screen.

Screenshot 2022-12-29 at 10 50 02 PM

@PeerRich
Copy link
Copy Markdown
Member

can you also get rid of the double border around that input select?

@PeerRich PeerRich requested a review from sean-brydon December 30, 2022 17:54
@PeerRich PeerRich added ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge labels Dec 30, 2022
@PeerRich PeerRich enabled auto-merge (squash) December 30, 2022 17:54
@github-actions github-actions Bot removed ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge labels Dec 30, 2022
@PeerRich PeerRich merged commit 518a448 into main Dec 30, 2022
@PeerRich PeerRich deleted the fix/dialog-scroll branch December 30, 2022 18:16
@Udit-takkar
Copy link
Copy Markdown
Contributor Author

@PeerRich okay will do that

@Udit-takkar Udit-takkar mentioned this pull request Jan 2, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants