Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CarinaWolli
commented
Feb 9, 2023
| }, | ||
| }); | ||
|
|
||
| await client.request({ |
Member
Author
There was a problem hiding this comment.
SendGrid saves canceled emails (until the scheduled date) and our max limit of saved entries was reached. So from now on we delete them right after canceling. I deleted all scheduled_sends from SendGrid, so it should already work again
| }, | ||
| }, | ||
| steps: true, | ||
| steps: { |
Member
Author
There was a problem hiding this comment.
this fixes that added steps were in wrong order on first load
| }); | ||
|
|
||
| // delete scheduled jobs of cancelled bookings | ||
| cancelScheduledJobs(bookingToReschedule); |
Member
Author
There was a problem hiding this comment.
cancel scheduledJobs and all workflow reminders for the booking if rescheudling is requested
5 tasks
5 tasks
This was referenced Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes issue that workflow email reminders of canceled bookings were still sent.
Fixes issue that bookings that requested rescheduling still sent SMS and email reminders.
Also, fixes the issue that when editing a workflow the data gets lost when clicking outside of the workflow.
Fixes #6973
Fixes #6905
Fixes #6956
Environment: Staging(main branch) / Production
Type of change