Skip to content

fix: use time format#8787

Merged
PeerRich merged 16 commits into
mainfrom
fix/email-time-format
Jul 28, 2023
Merged

fix: use time format#8787
PeerRich merged 16 commits into
mainfrom
fix/email-time-format

Conversation

@Udit-takkar

@Udit-takkar Udit-takkar commented May 9, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes #8746 ( 1 and 2)

Screenshot 2023-05-09 at 11 09 22 PM

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
@Udit-takkar Udit-takkar requested a review from zomars as a code owner May 9, 2023 17:39
@Udit-takkar Udit-takkar requested a review from a team May 9, 2023 17:39
@vercel

vercel Bot commented May 9, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 2:43pm
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 2:43pm
cal-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 2:43pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 2:43pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2024 2:43pm
dev ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2024 2:43pm
qa ⬜️ Ignored (Inspect) Mar 19, 2024 2:43pm

@github-actions github-actions Bot added High priority Created by Linear-GitHub Sync linear Sync Github Issue from community members to Linear.app 🐛 bug Something isn't working labels May 9, 2023
@github-actions

github-actions Bot commented May 9, 2023

Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel

deploysentinel Bot commented May 9, 2023

Copy link
Copy Markdown

Current Playwright Test Results Summary

✅ 106 Passing - ⚠️ 7 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/28/2023 01:03:19pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: f564c0a

Started: 07/28/2023 01:01:22pm UTC

⚠️ Flakes

📄   apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1Initial Attempt
1.50% (4) 4 / 267 runs
failed over last 7 days
37.08% (99) 99 / 267 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 4 Flakes

Top 1 Common Error Messages

null

4 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
0% (0) 0 / 223 runs
failed over last 7 days
11.21% (25) 25 / 223 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1Initial Attempt
1.35% (3) 3 / 223 runs
failed over last 7 days
95.07% (212) 212 / 223 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
0% (0) 0 / 223 runs
failed over last 7 days
5.38% (12) 12 / 223 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
3.57% (8) 8 / 224 runs
failed over last 7 days
4.02% (9) 9 / 224 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests user can add multiple organizer address
Retry 1Initial Attempt
0.72% (2) 2 / 279 runs
failed over last 7 days
14.34% (40) 40 / 279 runs
flaked over last 7 days

📄   apps/web/playwright/managed-event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Managed Event Types tests Can create managed event type
Retry 1Initial Attempt
1.08% (3) 3 / 279 runs
failed over last 7 days
10.75% (30) 30 / 279 runs
flaked over last 7 days

View Detailed Build Results


Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Comment thread packages/emails/templates/attendee-daily-video-download-recording-email.ts Outdated
Comment thread packages/emails/templates/organizer-scheduled-email.ts

@hariombalhara hariombalhara left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment. Will test after that. This is a critical flow. So, testing is super important.

@PeerRich PeerRich removed the linear Sync Github Issue from community members to Linear.app label May 26, 2023
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Comment thread packages/emails/templates/_base-email.ts Outdated
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
@keithwillcode

Copy link
Copy Markdown
Contributor

@shivamklr Could you test this one on a preview build before we merge to main?

@shivamklr shivamklr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested fix. Feel free to review the code.

@PeerRich

Copy link
Copy Markdown
Member

merged accidentially, @shivamklr @hariombalhara wanna test again once this hits app.cal.dev?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working core area: core, team members only Low priority Created by Linear-GitHub Sync

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

[CAL-1628] Wrong time format in emails and SMS

7 participants