fix: Make routing-form a preinstalled app by hariombalhara · Pull Request #9836 · calcom/cal.diy

hariombalhara · 2023-06-28T15:22:34Z

What does this PR do?

Fixes #10372
Fixes #9351

Routing Forms is a Default app now, globally installed.

It will remain accessible at/apps/routing-formsbut will be referred to as /routing-forms throughout the app.

Demo Loom

Type of change

Improvement

How should this be tested?

See the loom
You simply need to create a new account and you would see Routing Forms App preinstalled.

Mandatory Tasks

Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

I haven't checked if my changes generate no new warnings

linear · 2023-06-28T15:22:37Z

CAL-1869 Make Routing Form a core component.

We are going to support creating a Routing Form for a team.

After that, it would require all team members to be able to access a Routing Form(even if the Routing Form App isn't installed by that user).

So, it makes even more sense to move it to core now.

vercel · 2023-06-28T15:22:41Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 26, 2023 4:41pm
cal-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 26, 2023 4:41pm
dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 26, 2023 4:41pm
ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 26, 2023 4:41pm

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		Jul 26, 2023 4:41pm
qa	⬜️ Ignored (Inspect)			Jul 26, 2023 4:41pm

github-actions · 2023-06-28T15:22:48Z

Thank you for following the naming conventions! 🙏

github-actions · 2023-06-28T15:30:52Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

deploysentinel · 2023-06-28T15:32:30Z

Current Playwright Test Results Summary

✅ 105 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/26/2023 04:43:34pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 3307ac9

Started: 07/26/2023 04:41:26pm UTC

⚠️ Flakes

📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Stripe integration Can book a paid booking Retry 1 • Initial Attempt	1.63% (5) 5 / 307 runs failed over last 7 days	1.63% (5) 5 / 307 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should be able to reschedule Retry 1 • Initial Attempt	1.38% (3) 3 / 217 runs failed over last 7 days	98.16% (213) 213 / 217 runs flaked over last 7 days
Popup Tests should open embed iframe on click - Configured with light theme Retry 1 • Initial Attempt	0% (0) 0 / 216 runs failed over last 7 days	6.48% (14) 14 / 216 runs flaked over last 7 days

📄 apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
FORM_SUBMITTED can submit a form and get a submission event Retry 1 • Initial Attempt	1.94% (6) 6 / 309 runs failed over last 7 days	7.44% (23) 23 / 309 runs flaked over last 7 days

View Detailed Build Results

github-actions · 2023-07-13T00:20:11Z

This PR is being marked as stale due to inactivity.

…routing-form-a-core-component

hariombalhara · 2023-07-26T05:20:50Z

 };

 function useShouldDisplayNavigationItem(item: NavigationItemType) {
-  const { status } = useSession();


No condition needed now.

hariombalhara · 2023-07-26T05:21:22Z

      const path = router.asPath.split("?")[0];
      // During Server rendering path is /v2/apps but on client it becomes /apps(weird..)
-      return (
-        (path.startsWith(item.href) || path.startsWith("/v2" + item.href)) && !path.includes("routing-forms/")


We would be accessing routing-forms as /routing-forms now instead of /apps/routing-forms. So, Apps navigation item doesn't need to detect if it's Routing Form or App that's selected.

hariombalhara · 2023-07-26T05:22:09Z

          destination: "/booking/:path*",
        },
+        {
+          source: "/routing-forms/:slug*",


Routing Forms is now system app. So, allow accessing it directly. This also allows us to never have to move Routing Forms app outside AppStore unless needed for some other reason.

hariombalhara · 2023-07-26T05:22:25Z

  "/*": "Don't modify slug - If required, do it using cli edit command",
  "name": "Routing Forms",
  "title": "Routing Forms",
+  "isGlobal": true,


Make Routing Forms app preinstalled.

…ponent

CarinaWolli · 2023-07-26T16:31:27Z

+      return NextResponse.rewrite(url);
+    }
+
+    // Don't 404 old routing_forms links


/apps/routing_forms does 404 for me, should that work?

Fixed it here. #10412. Should have worked

zomars

Looks good enough to ship. We might depart from all [...pages] and [...appPages] in the future and give it a proper location in their respective directories.

Co-authored-by: zomars <zomars@me.com>

WIP

87e90be

hariombalhara changed the title ~~WIP~~ fix: Make routing Forms a system app Jun 28, 2023

github-actions Bot added the Stale label Jul 13, 2023

hariombalhara removed the Stale label Jul 13, 2023

PeerRich added the core area: core, team members only label Jul 21, 2023

Merge remote-tracking branch 'origin/main' into hariom/cal-1869-make-…

27e893f

…routing-form-a-core-component

vercel Bot had a problem deploying to Preview – api July 26, 2023 04:58 Failure

vercel Bot deployed to Preview – ui July 26, 2023 04:58 View deployment

vercel Bot had a problem deploying to Preview – cal-demo July 26, 2023 04:59 Failure

vercel Bot had a problem deploying to Preview – dev July 26, 2023 05:01 Failure

hariombalhara force-pushed the hariom/cal-1869-make-routing-form-a-core-component branch from 154c8d9 to 091c02a Compare July 26, 2023 05:19

hariombalhara commented Jul 26, 2023

View reviewed changes

hariombalhara force-pushed the hariom/cal-1869-make-routing-form-a-core-component branch from 091c02a to c15a313 Compare July 26, 2023 05:22

vercel Bot had a problem deploying to Preview – cal-demo July 26, 2023 05:30 Failure

vercel Bot had a problem deploying to Preview – api July 26, 2023 05:30 Failure

vercel Bot deployed to Preview – ui July 26, 2023 05:30 View deployment

vercel Bot had a problem deploying to Preview – dev July 26, 2023 05:33 Failure

Fixes

290de0d

hariombalhara force-pushed the hariom/cal-1869-make-routing-form-a-core-component branch from b5872cb to 290de0d Compare July 26, 2023 06:22

vercel Bot deployed to Preview – ui July 26, 2023 06:25 View deployment

vercel Bot had a problem deploying to Preview – cal-demo July 26, 2023 06:26 Failure

hariombalhara marked this pull request as ready for review July 26, 2023 11:00

hariombalhara added High priority Created by Linear-GitHub Sync organizations area: organizations, orgs labels Jul 26, 2023

hariombalhara self-assigned this Jul 26, 2023

hariombalhara requested review from a team July 26, 2023 11:01

vercel Bot deployed to Preview – ui July 26, 2023 11:04 View deployment

vercel Bot deployed to Preview – dev July 26, 2023 11:05 View deployment

vercel Bot deployed to Preview – cal-demo July 26, 2023 11:07 View deployment

vercel Bot deployed to Preview – api July 26, 2023 11:07 View deployment

keithwillcode requested a review from zomars July 26, 2023 13:59

Merge branch 'main' into hariom/cal-1869-make-routing-form-a-core-com…

0845bc1

…ponent

vercel Bot deployed to Preview – ui July 26, 2023 16:29 View deployment

vercel Bot deployed to Preview – dev July 26, 2023 16:30 View deployment

vercel Bot deployed to Preview – api July 26, 2023 16:31 View deployment

CarinaWolli reviewed Jul 26, 2023

View reviewed changes

vercel Bot deployed to Preview – cal-demo July 26, 2023 16:31 View deployment

zomars reviewed Jul 26, 2023

View reviewed changes

Comment thread packages/types/App.d.ts Outdated

Update packages/types/App.d.ts

3307ac9

zomars approved these changes Jul 26, 2023

View reviewed changes

zomars enabled auto-merge (squash) July 26, 2023 16:34

vercel Bot deployed to Preview – ui July 26, 2023 16:37 View deployment

vercel Bot deployed to Preview – dev July 26, 2023 16:38 View deployment

vercel Bot deployed to Preview – api July 26, 2023 16:38 View deployment

vercel Bot deployed to Preview – cal-demo July 26, 2023 16:41 View deployment

zomars merged commit f1acedf into main Jul 26, 2023

zomars deleted the hariom/cal-1869-make-routing-form-a-core-component branch July 26, 2023 16:44

joeauyeung pushed a commit that referenced this pull request Jul 26, 2023

fix: Make routing-form a preinstalled app (#9836)

7ec1568

Co-authored-by: zomars <zomars@me.com>

sean-brydon pushed a commit that referenced this pull request Jul 31, 2023

fix: Make routing-form a preinstalled app (#9836)

1ace1f7

Co-authored-by: zomars <zomars@me.com>

sean-brydon pushed a commit that referenced this pull request Aug 1, 2023

fix: Make routing-form a preinstalled app (#9836)

c2815e5

Co-authored-by: zomars <zomars@me.com>

Uh oh!

Conversation

hariombalhara commented Jun 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Type of change

How should this be tested?

Mandatory Tasks

Checklist

Uh oh!

linear Bot commented Jun 28, 2023

Uh oh!

vercel Bot commented Jun 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Next.js Bundle Analysis for @calcom/web

Uh oh!

deploysentinel Bot commented Jun 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Uh oh!

github-actions Bot commented Jul 13, 2023

Uh oh!

hariombalhara Jul 26, 2023

Choose a reason for hiding this comment

Uh oh!

hariombalhara Jul 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hariombalhara Jul 26, 2023

Choose a reason for hiding this comment

Uh oh!

hariombalhara Jul 26, 2023

Choose a reason for hiding this comment

Uh oh!

CarinaWolli Jul 26, 2023

Choose a reason for hiding this comment

Uh oh!

hariombalhara Jul 27, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zomars left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hariombalhara commented Jun 28, 2023 •

edited

Loading

vercel Bot commented Jun 28, 2023 •

edited

Loading

github-actions Bot commented Jun 28, 2023 •

edited

Loading

github-actions Bot commented Jun 28, 2023 •

edited

Loading

deploysentinel Bot commented Jun 28, 2023 •

edited

Loading

hariombalhara Jul 26, 2023 •

edited

Loading