fix: wrong slot starting times for half hour times zones#10161
Merged
fix: wrong slot starting times for half hour times zones#10161
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
github-actions
Bot
added
High priority
CarinaWolli
changed the title
|
🤖 Meticulous spotted visual differences in 109 of 193 screens tested: view and approve differences detected. Last updated for commit 393a005. This comment will update as new commits are pushed. |
CarinaWolli
changed the title
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
No failed tests 🎉 |
Member
Author
|
Looking at the one failed test EDIT: tests are fixed |
1 task
alannnc
reviewed
Jul 14, 2023
alannnc
previously approved these changes
Jul 14, 2023
Contributor
alannnc
left a comment
alannnc
left a comment
There was a problem hiding this comment.
Code looks good! If test pass we should merge now.
alannnc
approved these changes
Jul 17, 2023
fritterhoff
pushed a commit
to hm-edu/cal.com
that referenced
this pull request
Jul 25, 2023
* fix timezone zone issue for first slot * fix failed test in getSchedule * Update apps/web/test/lib/getSchedule.test.ts --------- Co-authored-by: CarinaWolli <wollencarina@gmail.com> Co-authored-by: alannnc <alannnc@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes that UTC was used to find the time of the first slot. This resulted in wrong slot times for timezones that are not full hours like Asia/Kolkata +5:30.
Example:
availability: 7:30 - 12:00 (+5:30)
Slots for hourly event before:
Slots for hourly event after:
Fixes #10136
Type of change
How should this be tested?