-
Notifications
You must be signed in to change notification settings - Fork 13.1k
fix: initialized flags on event-types page #13469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
0bfd724
0809613
842e639
d7157fc
6fcf6fb
d786a37
6f4e91f
7874a23
bc9c9cf
c3a6aa4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import type { GetServerSidePropsContext } from "next"; | ||
|
|
||
| import { getServerSession } from "@calcom/features/auth/lib/getServerSession"; | ||
|
|
||
| import { ssrInit } from "@server/lib/ssr"; | ||
|
|
||
| export const getServerSideProps = async (context: GetServerSidePropsContext) => { | ||
| const ssr = await ssrInit(context); | ||
| const session = await getServerSession({ req: context.req, res: context.res }); | ||
|
|
||
| if (!session) { | ||
| return { | ||
| redirect: { | ||
| redirect: { | ||
| permanent: false, | ||
| destination: "/auth/login", | ||
| }, | ||
| }, | ||
| }; | ||
| } | ||
|
|
||
| return { props: { trpcState: ssr.dehydrate() } }; | ||
| }; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| -- revert 20230404202721_add_feature_flag_managed_event_types | ||
|
|
||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why are we deleting this feature flag?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
i thought @PeerRich meant its not need anymore, so removed it
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, i am ok removing this. this was used to roll it out slowly but now managed event types is a core part of our offering and doenst need a feature flag imo |
||
| DELETE FROM "Feature" WHERE slug = 'managed-event-types'; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we even need this if we remove the feature flag for managed event types?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we should still include this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok.
btw. end to end tests failing, not sure if its related to this PR @keithwillcode ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s not unfortunately. We have E2E test suite issues at the moment. Hoping to resolve by tomorrow and will get this merged.