fix: Snippet path in preview#14830
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @hariombalhara and the rest of your teammates on |
dosubot
Bot
added
automated-tests
| p(cal, ar); | ||
| }; | ||
| })(window, "//localhost:3000/embed/embed.js", "init"); | ||
| })(window, embedLibUrl, "init"); |
There was a problem hiding this comment.
It was an accidental change that got committed.
https://github.com/calcom/cal.com/pull/13386/files#r1586013449
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (05/01/24)1 reviewer was added to this PR based on Keith Williams's automation. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 25 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 05/02/2024 04:03:05pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: d5a0a1f Started: 05/02/2024 04:01:25pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1 • Initial Attempt |
7.50% (21)21 / 280 runsfailed over last 7 days |
33.93% (95)95 / 280 runsflaked over last 7 days |
sean-brydon
left a comment
sean-brydon
left a comment
There was a problem hiding this comment.
Tested - LGTM
thanks for tests <3
* fix: Snippet path in preview * Add test
4 participants
What does this PR do?
Fixes #14831
Fixes CAL-3598
Regression from https://github.com/calcom/cal.com/pull/13386/files#r1586013449
Added a regression test as well. The tests were there for preview flow but the bug caused the localhost:3000 to be hardcoded, they were all running fine as localhost:3000 is setup properly in CI as well but not in production.
Added a test now to ensure that
embedLibUrlis being used.Type of change
How should this be tested?
Pretty straightforward revert. So, nothing to test. Added an automation scenario as well.
Also, it can't be replicated easily locally.
Mandatory Tasks