chore: routingform org attribute seed by sean-brydon · Pull Request #17510 · calcom/cal.diy

sean-brydon · 2024-11-06T11:37:44Z

What does this PR do?

This PR adds a way to seed a organization with routing forms and attirbutes.

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Reset your DB.
Run migrations
Run yarn seed (This should create an acme organization with now 10 users to make this a bit easier - you can change this value if you want more users in your org).
Run yarn seed-insights - This will seed the "Acme" org with a bunch of data. Previous bookings, Teams, Routing forms and attributes

Checklist

I haven't read the contributing guide
My code doesn't follow the style guidelines of this project
I haven't commented my code, particularly in hard-to-understand areas
I haven't checked if my changes generate no new warnings

github-actions · 2024-11-06T11:37:56Z

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

Unknown release type "core" found in pull request title "core: routingform org attribute seed". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

vercel · 2024-11-06T11:39:03Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		Nov 14, 2024 4:27pm
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview		Nov 14, 2024 4:27pm

sean-brydon · 2024-11-06T11:38:05Z

Will remove

sean-brydon · 2024-11-06T11:39:24Z

-          ],
-        },
-        {
+        ...Array.from({ length: 10 }, (_, i) => ({


Creates 10 members . Feel free to change length to anything you want to test orgs

sean-brydon · 2024-11-06T11:39:57Z

+
+  const attributeRaw: { id: string; options: { id: string; value: string }[] }[] = [];
+
+  for (const attr of mockAttributes) {


Assign users random attributes

sean-brydon · 2024-11-06T11:40:16Z

+      {
+        id: "8a898988-89ab-4cde-b012-31823f708642",
+        value: "team/insights-team/team-javascript",
+      },
+      {
+        id: "8b2224b2-89ab-4cde-b012-31823f708642",
+        value: "team/insights-team/team-sales",
+      },


Key info needed that can't change as its used in routingFormResponses

sean-brydon · 2024-11-06T11:40:28Z

+      },
+    ],
+    formFieldFilled: {
+      id: "83316968-45bf-4c9d-b5d4-5368a8d2d2a8",


This formField that is filled when the users previews the attribute

sean-brydon · 2024-11-06T11:40:44Z

+  if (attributeRaw.length === 0) {
+    throw new Error("No attributes found - Please call seedAttributes first");
+  }


Make this dependant on attributes

sean-brydon · 2024-11-06T11:41:16Z

+                properties: {
+                  field: attributeRaw[2].id,
+                  value: [
+                    attributeRaw[2].options.filter((opt) => opt.value === "JavaScript").map((opt) => opt.id),


This currently relys on the set attributeArray being passed in. Down the line we can make this more flexible of a factory if we really need

sean-brydon · 2024-11-06T11:41:27Z

+      ],
+      fields: [
+        {
+          id: seededForm.formFieldFilled.id,


The field ID we use to fill in the form

sean-brydon · 2024-11-06T11:41:38Z

+          options: attributeRaw[2].options.map((opt) => ({
+            id: opt.id,
+            label: opt.value,
+          })),


Make sure options and id are the same so we can link to responses

sean-brydon · 2024-11-06T11:42:32Z

+      response: {
+        [seededForm.formFieldFilled.id]: {
+          label: "skills",
+          value: selectedSkills.map((opt) => opt.id),


We can pass multiple responses in here Note: These responses may not match the rules that are created. They are just for visual and display purposes for insights.

sean-brydon · 2024-11-06T11:43:39Z

    },
-  });
-
-  if (!insightsAdmin) {


Note we may need to add this user back. I'm pretty sure it is used in a e2e test. Will check just wanted to get this out for early reviews

graphite-app · 2024-11-06T11:45:12Z

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (11/06/24)

1 reviewer was added to this PR based on Keith Williams's automation.

hariombalhara · 2024-11-06T11:52:28Z

Works great !!

PeerRich · 2024-11-08T11:05:32Z

test failing @sean-brydon

github-actions · 2024-11-11T14:14:30Z

E2E results are ready!

Workflow #37883.2 latest results

sean-brydon · 2024-11-14T16:24:17Z

        where: { email: "member2-acme@example.com" },
      });

-      expect(accessibleUserIds.length).toBe(3);


Matches new count

sean-brydon added 4 commits November 6, 2024 09:14

seed to org

1803242

more org+routing form seed improvments

b0d8a93

add routing responses

9937564

check if attributes already exist to prevent crash

fb328b8

dosubot Bot added organizations area: organizations, orgs routing-forms area: routing forms, routing, forms labels Nov 6, 2024

keithwillcode added consumer core area: core, team members only labels Nov 6, 2024

remove files not for PR

a826a5d

graphite-app Bot requested a review from a team November 6, 2024 11:40

sean-brydon commented Nov 6, 2024

View reviewed changes

sean-brydon changed the title ~~core: routingform org attribute seed~~ chore: routingform org attribute seed Nov 6, 2024

sean-brydon commented Nov 6, 2024

View reviewed changes

fix type error

8c52a44

vercel Bot deployed to Preview – api November 6, 2024 11:53 View deployment

vercel Bot deployed to Preview – dev November 6, 2024 12:07 View deployment

sean-brydon added 2 commits November 6, 2024 13:41

fix connection

3423091

assign manually

4a9ebb1

vercel Bot deployed to Preview – api November 6, 2024 14:33 View deployment

vercel Bot deployed to Preview – dev November 6, 2024 14:40 View deployment

sean-brydon added 2 commits November 7, 2024 08:12

Merge branch 'main' into feat/routingform-org-attribute-seed

1415019

fix seed

0032684

vercel Bot deployed to Preview – api November 7, 2024 08:35 View deployment

vercel Bot deployed to Preview – dev November 7, 2024 08:43 View deployment

Merge branch 'main' into feat/routingform-org-attribute-seed

57817dc

vercel Bot deployed to Preview – api November 7, 2024 22:49 View deployment

vercel Bot deployed to Preview – dev November 7, 2024 22:57 View deployment

Merge branch 'main' into feat/routingform-org-attribute-seed

6706ada

vercel Bot deployed to Preview – api November 11, 2024 08:16 View deployment

vercel Bot deployed to Preview – dev November 11, 2024 08:23 View deployment

sean-brydon added the ready-for-e2e label Nov 11, 2024

update to match integration tests

c4e9fdb

vercel Bot deployed to Preview – api November 14, 2024 08:29 View deployment

vercel Bot deployed to Preview – dev November 14, 2024 08:36 View deployment

fix integration test to new user count

4132fe8

vercel Bot deployed to Preview – api November 14, 2024 13:00 View deployment

vercel Bot deployed to Preview – dev November 14, 2024 13:09 View deployment

sean-brydon mentioned this pull request Nov 14, 2024

feat: insights routing forms #17583

Merged

3 tasks

sean-brydon commented Nov 14, 2024

View reviewed changes

Merge branch 'main' into feat/routingform-org-attribute-seed

ae33741

vercel Bot deployed to Preview – api November 14, 2024 16:35 View deployment

vercel Bot deployed to Preview – dev November 14, 2024 16:43 View deployment

keithwillcode approved these changes Nov 14, 2024

View reviewed changes

keithwillcode merged commit 12c5005 into main Nov 14, 2024

keithwillcode deleted the feat/routingform-org-attribute-seed branch November 14, 2024 17:50


		const attributeRaw: { id: string; options: { id: string; value: string }[] }[] = [];

		for (const attr of mockAttributes) {

Conversation

sean-brydon commented Nov 6, 2024

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

How should this be tested?

Checklist

Uh oh!

github-actions Bot commented Nov 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel Bot commented Nov 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

graphite-app Bot commented Nov 6, 2024

Graphite Automations

Uh oh!

hariombalhara commented Nov 6, 2024

Uh oh!

PeerRich commented Nov 8, 2024

Uh oh!

github-actions Bot commented Nov 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E results are ready!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Nov 6, 2024 •

edited

Loading

vercel Bot commented Nov 6, 2024 •

edited

Loading

github-actions Bot commented Nov 11, 2024 •

edited

Loading