feat: add instant meeting parameter#17647
Merged
Udit-takkar merged 7 commits intomainfrom Nov 18, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
keithwillcode
added
core
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (11/15/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (11/18/24)1 label was added to this PR based on Keith Williams's automation. |
Udit-takkar
commented
Nov 15, 2024
Comment on lines
+72
to
+77
| const searchParams = useSearchParams(); | ||
|
|
||
| const areInstantMeetingParametersSet = !!event.data?.instantMeetingParameters | ||
| ? event.data.instantMeetingParameters.every((param) => Array.from(searchParams.values()).includes(param)) | ||
| : true; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
if there are instantMeetingParameters then all of them should be present
Udit-takkar
commented
Nov 15, 2024
Comment on lines
+179
to
+181
| <div> | ||
| <Label>{t("only_show_if_parameter_set")}</Label> | ||
| <div className="space-y-2"> |
Contributor
Author
There was a problem hiding this comment.
In the next iteration i would be refactoring it to something like this
Udit-takkar
commented
Nov 15, 2024
Comment on lines
+79
to
+82
| const [parameters, setParameters] = useState<string[]>( | ||
| formMethods.getValues("instantMeetingParameters") || [] | ||
| ); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I tried using useFieldArray but it had some issues and type errors
Contributor
Author
There was a problem hiding this comment.
- It was splitting the string to object like { 1: "I", 2: "N" , 3 :"D" }.
and it's mentioned in the docs that useFieldArray doesn't support flat field arrays.
Contributor
E2E results are ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?